Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1388)

Unified Diff: Source/core/rendering/style/RenderStyleConstants.h

Issue 57493002: Remove 'alphabetic' value from text-underline-position (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/rendering/style/RenderStyleConstants.h
diff --git a/Source/core/rendering/style/RenderStyleConstants.h b/Source/core/rendering/style/RenderStyleConstants.h
index 359bd551eb283e418418e1050823fec1abc45c76..5d0eadfd35ef3c5dc706c16db4ba20207f2114ce 100644
--- a/Source/core/rendering/style/RenderStyleConstants.h
+++ b/Source/core/rendering/style/RenderStyleConstants.h
@@ -378,8 +378,9 @@ enum TextJustify {
};
enum TextUnderlinePosition {
- // FIXME: Implement support for 'under left' and 'under right' values.
Julien - ping for review 2013/11/04 16:06:43 I think the old comment still applies as we need t
abinader 2013/11/04 16:38:02 Ack!
- TextUnderlinePositionAuto = 0x1, TextUnderlinePositionAlphabetic = 0x2, TextUnderlinePositionUnder = 0x4
+ // FIXME: Implement support for 'left' and 'right' values.
+ TextUnderlinePositionAuto = 0x1,
+ TextUnderlinePositionUnder = 0x2
};
enum EPageBreak {

Powered by Google App Engine
This is Rietveld 408576698