Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: LayoutTests/fast/css3-text/css3-text-decoration/getComputedStyle/script-tests/getComputedStyle-text-underline-position.js

Issue 57493002: Remove 'alphabetic' value from text-underline-position (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/fast/css3-text/css3-text-decoration/getComputedStyle/script-tests/getComputedStyle-text-underline-position.js
diff --git a/LayoutTests/fast/css3-text/css3-text-decoration/getComputedStyle/script-tests/getComputedStyle-text-underline-position.js b/LayoutTests/fast/css3-text/css3-text-decoration/getComputedStyle/script-tests/getComputedStyle-text-underline-position.js
index a18322e560ceb0cbb6b05a6c1270218a3307405a..8fa53c405a44c7cfa2c4d61069a27ccf265989df 100644
--- a/LayoutTests/fast/css3-text/css3-text-decoration/getComputedStyle/script-tests/getComputedStyle-text-underline-position.js
+++ b/LayoutTests/fast/css3-text/css3-text-decoration/getComputedStyle/script-tests/getComputedStyle-text-underline-position.js
@@ -18,7 +18,7 @@ function testComputedStyle(propertyJS, propertyCSS, type, value)
description("Test to make sure text-underline-position property returns values properly.")
-// FIXME: This test tests property values 'auto', 'alphabetic' and 'under'. We don't fully match
+// FIXME: This test tests property values 'auto' and 'under'. We don't fully match
// the specification as we don't support [ left | right ] and this is left for another implementation
// as the rendering will need to be added.
@@ -52,12 +52,6 @@ testElementStyle("textUnderlinePosition", "text-underline-position", "[object CS
testComputedStyle("textUnderlinePosition", "text-underline-position", "[object CSSPrimitiveValue]", "auto");
debug('');
-debug("Value 'alphabetic':");
-e.style.textUnderlinePosition = 'alphabetic';
-testElementStyle("textUnderlinePosition", "text-underline-position", "[object CSSPrimitiveValue]", "alphabetic");
-testComputedStyle("textUnderlinePosition", "text-underline-position", "[object CSSPrimitiveValue]", "alphabetic");
-debug('');
-
debug("Value 'under':");
e.style.textUnderlinePosition = 'under';
testElementStyle("textUnderlinePosition", "text-underline-position", "[object CSSPrimitiveValue]", "under");
@@ -71,23 +65,18 @@ testElementStyle("textUnderlinePosition", "text-underline-position", null, "");
testComputedStyle("textUnderlinePosition", "text-underline-position", "[object CSSPrimitiveValue]", "under");
debug('');
-debug("Value 'auto alphabetic':");
-e.style.textUnderlinePosition = 'auto alphabetic';
-testElementStyle("textUnderlinePosition", "text-underline-position", null, "");
-debug('');
-
debug("Value 'auto under':");
e.style.textUnderlinePosition = 'auto under';
testElementStyle("textUnderlinePosition", "text-underline-position", null, "");
debug('');
-debug("Value 'under under':");
-e.style.textUnderlinePosition = 'under under';
+debug("Value 'under auto':");
+e.style.textUnderlinePosition = 'under auto';
Julien - ping for review 2013/11/04 16:06:43 Please don't change the test, this was here to tes
abinader 2013/11/04 16:38:02 Got that, will undo.
testElementStyle("textUnderlinePosition", "text-underline-position", null, "");
debug('');
-debug("Value 'under under under':");
-e.style.textUnderlinePosition = 'auto alphabetic under';
+debug("Value 'unknown':");
+e.style.textUnderlinePosition = 'unknown';
testElementStyle("textUnderlinePosition", "text-underline-position", null, "");
debug('');

Powered by Google App Engine
This is Rietveld 408576698