Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 574803002: [NaCl SDK] nacl_io: Fix excess realloc'ing in memfs nodes. (Closed)

Created:
6 years, 3 months ago by Sam Clegg
Modified:
6 years, 3 months ago
Reviewers:
bradnelson, bradn, binji
CC:
chromium-reviews, binji+watch_chromium.org, Sam Clegg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[NaCl SDK] nacl_io: Fix excess realloc'ing in memfs nodes. This was causes extreme performance issues when untaring large files in naclports (specifically with python). Committed: https://crrev.com/314a240ec3fd6a40f9e2e543fa692eb44d667ab2 Cr-Commit-Position: refs/heads/master@{#295299}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -11 lines) Patch
M native_client_sdk/src/libraries/nacl_io/memfs/mem_fs.cc View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/libraries/nacl_io/memfs/mem_fs_node.cc View 1 2 1 chunk +15 lines, -10 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Sam Clegg
6 years, 3 months ago (2014-09-17 01:22:07 UTC) #2
bradn
lgtm
6 years, 3 months ago (2014-09-17 16:44:58 UTC) #4
binji
lgtm
6 years, 3 months ago (2014-09-17 16:49:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/574803002/40001
6 years, 3 months ago (2014-09-17 17:20:12 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001) as 5124fbd51d2e765be8d79c8a68ec39c5179746f0
6 years, 3 months ago (2014-09-17 18:11:39 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-17 18:12:30 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/314a240ec3fd6a40f9e2e543fa692eb44d667ab2
Cr-Commit-Position: refs/heads/master@{#295299}

Powered by Google App Engine
This is Rietveld 408576698