native_client_sdk/src/libraries/nacl_io/memfs/mem_fs.cc - Issue 574803002: [NaCl SDK] nacl_io: Fix excess realloc'ing in memfs nodes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: native_client_sdk/src/libraries/nacl_io/memfs/mem_fs.cc

Issue 574803002: [NaCl SDK] nacl_io: Fix excess realloc'ing in memfs nodes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: native_client_sdk/src/libraries/nacl_io/memfs/mem_fs.cc

diff --git a/native_client_sdk/src/libraries/nacl_io/memfs/mem_fs.cc b/native_client_sdk/src/libraries/nacl_io/memfs/mem_fs.cc

index 111dc6f2e396ea05114e7c0df8907c83a1134f69..118874dc18346112c28f035f1f709f4bb5742fb9 100644

--- a/native_client_sdk/src/libraries/nacl_io/memfs/mem_fs.cc

+++ b/native_client_sdk/src/libraries/nacl_io/memfs/mem_fs.cc

@@ -114,7 +114,7 @@ Error MemFs::OpenWithMode(const Path& path, int open_flags, mode_t mode,

return EEXIST;

if (open_flags & O_TRUNC)

- static_cast<MemFsNode*>(node.get())->Resize(0);

+ node->FTruncate(0);

}

*out_node = node;

« no previous file with comments | « no previous file | native_client_sdk/src/libraries/nacl_io/memfs/mem_fs_node.cc » ('j') | no next file with comments »