Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 57463009: [sql] Track data recovered in Favicons recovery. (Closed)

Created:
7 years, 1 month ago by Scott Hess - ex-Googler
Modified:
7 years, 1 month ago
Reviewers:
sky
CC:
chromium-reviews, browser-components-watch_chromium.org
Visibility:
Public.

Description

[sql] Track data recovered in Favicons recovery. r232635 landed the histograms, but forgot to populate the data submitted from GetLastChangeCount(). BUG=240396 NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232903

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M chrome/browser/history/thumbnail_database.cc View 3 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Scott Hess - ex-Googler
My most embarrassing CL from last week: https://codereview.chromium.org/49673006 at least I got it in, but ...
7 years, 1 month ago (2013-11-04 21:07:57 UTC) #1
sky
Ha, LGTM
7 years, 1 month ago (2013-11-04 21:42:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shess@chromium.org/57463009/1
7 years, 1 month ago (2013-11-04 21:52:41 UTC) #3
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) ui_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_simulator&number=98748
7 years, 1 month ago (2013-11-05 00:42:35 UTC) #4
Scott Hess - ex-Googler
On 2013/11/05 00:42:35, I haz the power (commit-bot) wrote: > Retried try job too often ...
7 years, 1 month ago (2013-11-05 03:06:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shess@chromium.org/57463009/1
7 years, 1 month ago (2013-11-05 04:03:45 UTC) #6
commit-bot: I haz the power
7 years, 1 month ago (2013-11-05 04:25:31 UTC) #7
Message was sent while issue was closed.
Change committed as 232903

Powered by Google App Engine
This is Rietveld 408576698