Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 49673006: [sql] Ship Favicons recovery code to beta and stable. (Closed)

Created:
7 years, 1 month ago by Scott Hess - ex-Googler
Modified:
7 years, 1 month ago
CC:
chromium-reviews, Ilya Sherman, browser-components-watch_chromium.org, jar (doing other things), asvitkine+watch_chromium.org, pkotwicz
Visibility:
Public.

Description

[sql] Ship Favicons recovery code to beta and stable. The code has been running without event on dev and canary for many weeks, the histograms have changed in a manner consistent with databases no longer being corrupt. Everyone should share this. Add some histograms to track the amount of data recovered. BUG=240396 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232635

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -10 lines) Patch
M chrome/browser/history/thumbnail_database.cc View 3 chunks +36 lines, -10 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +26 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Scott Hess - ex-Googler
jar@ for histograms sky@ for code change. pkotwicz@ just FYI. The branch is coming, so ...
7 years, 1 month ago (2013-11-01 23:56:01 UTC) #1
sky
LGTM
7 years, 1 month ago (2013-11-02 00:04:44 UTC) #2
jar (doing other things)
LGTM histograms.xml
7 years, 1 month ago (2013-11-02 00:07:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shess@chromium.org/49673006/1
7 years, 1 month ago (2013-11-02 00:19:03 UTC) #4
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=217962
7 years, 1 month ago (2013-11-02 03:51:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shess@chromium.org/49673006/1
7 years, 1 month ago (2013-11-02 05:41:25 UTC) #6
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=96747
7 years, 1 month ago (2013-11-02 07:56:18 UTC) #7
Scott Hess - ex-Googler
On 2013/11/02 07:56:18, I haz the power (commit-bot) wrote: > Retried try job too often ...
7 years, 1 month ago (2013-11-02 15:54:24 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shess@chromium.org/49673006/1
7 years, 1 month ago (2013-11-02 15:54:49 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shess@chromium.org/49673006/1
7 years, 1 month ago (2013-11-02 19:34:50 UTC) #10
commit-bot: I haz the power
7 years, 1 month ago (2013-11-02 21:08:30 UTC) #11
Message was sent while issue was closed.
Change committed as 232635

Powered by Google App Engine
This is Rietveld 408576698