Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 57453002: ash: Rename LauncherButtonHost to ShelfButtonHost. (Closed)

Created:
7 years, 1 month ago by tfarina
Modified:
7 years, 1 month ago
CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org
Visibility:
Public.

Description

ash: Rename LauncherButtonHost to ShelfButtonHost. - move launcher_button_host.h from launcher/ to shelf/ - rename to shelf_button_host.h BUG=248353 TEST=None, no functional changes R=harrym@chromium.org,jamescook@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233337

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -177 lines) Patch
M ash/ash.gyp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M ash/launcher/launcher_button.h View 5 chunks +5 lines, -5 lines 0 comments Download
M ash/launcher/launcher_button.cc View 5 chunks +10 lines, -10 lines 0 comments Download
D ash/launcher/launcher_button_host.h View 1 chunk +0 lines, -67 lines 0 comments Download
M ash/shelf/alternate_app_list_button.h View 2 chunks +7 lines, -7 lines 0 comments Download
M ash/shelf/alternate_app_list_button.cc View 4 chunks +9 lines, -9 lines 0 comments Download
M ash/shelf/app_list_button.h View 2 chunks +4 lines, -5 lines 0 comments Download
M ash/shelf/app_list_button.cc View 3 chunks +6 lines, -6 lines 0 comments Download
A + ash/shelf/shelf_button_host.h View 3 chunks +7 lines, -7 lines 0 comments Download
M ash/shelf/shelf_view.h View 3 chunks +9 lines, -11 lines 0 comments Download
M ash/shelf/shelf_view.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M ash/shelf/shelf_view_unittest.cc View 13 chunks +43 lines, -47 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
tfarina
7 years, 1 month ago (2013-11-03 21:43:57 UTC) #1
tfarina
ping?
7 years, 1 month ago (2013-11-04 23:57:21 UTC) #2
Harry McCleave
lgtm
7 years, 1 month ago (2013-11-05 00:01:13 UTC) #3
James Cook
lgtm
7 years, 1 month ago (2013-11-05 00:33:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/57453002/20001
7 years, 1 month ago (2013-11-05 02:39:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/57453002/20001
7 years, 1 month ago (2013-11-05 03:24:25 UTC) #6
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=184809
7 years, 1 month ago (2013-11-05 05:19:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/57453002/20001
7 years, 1 month ago (2013-11-05 15:04:20 UTC) #8
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=219680
7 years, 1 month ago (2013-11-05 17:10:01 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/57453002/320001
7 years, 1 month ago (2013-11-05 21:49:03 UTC) #10
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) interactive_ui_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=185487
7 years, 1 month ago (2013-11-05 23:14:32 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/57453002/320001
7 years, 1 month ago (2013-11-05 23:33:44 UTC) #12
commit-bot: I haz the power
Retried try job too often on linux_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura&number=94335
7 years, 1 month ago (2013-11-06 03:27:51 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/57453002/320001
7 years, 1 month ago (2013-11-06 03:56:39 UTC) #14
commit-bot: I haz the power
Retried try job too often on linux_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura&number=94568
7 years, 1 month ago (2013-11-06 07:32:08 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/57453002/320001
7 years, 1 month ago (2013-11-06 16:10:49 UTC) #16
commit-bot: I haz the power
7 years, 1 month ago (2013-11-06 20:20:36 UTC) #17
Message was sent while issue was closed. 
Change committed as 233337

Powered by Google App Engine
This is Rietveld 408576698