Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Unified Diff: net/cert/nss_cert_database_chromeos_unittest.cc

Issue 574513003: Remove implicit conversions from scoped_refptr to T* in net (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/ssl/client_cert_store_chromeos_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/cert/nss_cert_database_chromeos_unittest.cc
diff --git a/net/cert/nss_cert_database_chromeos_unittest.cc b/net/cert/nss_cert_database_chromeos_unittest.cc
index 13396b6ebd66fc5669d50950a2086be0d483cb5a..5f790c99a4affce4e32c7325f7a0207e21882b1c 100644
--- a/net/cert/nss_cert_database_chromeos_unittest.cc
+++ b/net/cert/nss_cert_database_chromeos_unittest.cc
@@ -170,11 +170,11 @@ TEST_F(NSSCertDatabaseChromeOSTest, ImportCACerts) {
// Check that the imported certs only shows up in the list for the user that
// imported them.
- EXPECT_TRUE(IsCertInCertificateList(certs_1[0], user_1_certlist));
- EXPECT_FALSE(IsCertInCertificateList(certs_1[0], user_2_certlist));
+ EXPECT_TRUE(IsCertInCertificateList(certs_1[0].get(), user_1_certlist));
+ EXPECT_FALSE(IsCertInCertificateList(certs_1[0].get(), user_2_certlist));
- EXPECT_TRUE(IsCertInCertificateList(certs_2[0], user_2_certlist));
- EXPECT_FALSE(IsCertInCertificateList(certs_2[0], user_1_certlist));
+ EXPECT_TRUE(IsCertInCertificateList(certs_2[0].get(), user_2_certlist));
+ EXPECT_FALSE(IsCertInCertificateList(certs_2[0].get(), user_1_certlist));
// Run the message loop so the observer notifications get processed.
base::RunLoop().RunUntilIdle();
@@ -196,11 +196,13 @@ TEST_F(NSSCertDatabaseChromeOSTest, ImportCACerts) {
base::RunLoop().RunUntilIdle();
- EXPECT_TRUE(IsCertInCertificateList(certs_1[0], user_1_certlist_async));
- EXPECT_FALSE(IsCertInCertificateList(certs_1[0], user_2_certlist_async));
+ EXPECT_TRUE(IsCertInCertificateList(certs_1[0].get(), user_1_certlist_async));
+ EXPECT_FALSE(
+ IsCertInCertificateList(certs_1[0].get(), user_2_certlist_async));
- EXPECT_TRUE(IsCertInCertificateList(certs_2[0], user_2_certlist_async));
- EXPECT_FALSE(IsCertInCertificateList(certs_2[0], user_1_certlist_async));
+ EXPECT_TRUE(IsCertInCertificateList(certs_2[0].get(), user_2_certlist_async));
+ EXPECT_FALSE(
+ IsCertInCertificateList(certs_2[0].get(), user_1_certlist_async));
}
// Test that ImportServerCerts imports the cert to the correct slot, and that
@@ -236,11 +238,11 @@ TEST_F(NSSCertDatabaseChromeOSTest, ImportServerCert) {
// Check that the imported certs only shows up in the list for the user that
// imported them.
- EXPECT_TRUE(IsCertInCertificateList(certs_1[0], user_1_certlist));
- EXPECT_FALSE(IsCertInCertificateList(certs_1[0], user_2_certlist));
+ EXPECT_TRUE(IsCertInCertificateList(certs_1[0].get(), user_1_certlist));
+ EXPECT_FALSE(IsCertInCertificateList(certs_1[0].get(), user_2_certlist));
- EXPECT_TRUE(IsCertInCertificateList(certs_2[0], user_2_certlist));
- EXPECT_FALSE(IsCertInCertificateList(certs_2[0], user_1_certlist));
+ EXPECT_TRUE(IsCertInCertificateList(certs_2[0].get(), user_2_certlist));
+ EXPECT_FALSE(IsCertInCertificateList(certs_2[0].get(), user_1_certlist));
// Run the message loop so the observer notifications get processed.
base::RunLoop().RunUntilIdle();
@@ -259,11 +261,13 @@ TEST_F(NSSCertDatabaseChromeOSTest, ImportServerCert) {
base::RunLoop().RunUntilIdle();
- EXPECT_TRUE(IsCertInCertificateList(certs_1[0], user_1_certlist_async));
- EXPECT_FALSE(IsCertInCertificateList(certs_1[0], user_2_certlist_async));
+ EXPECT_TRUE(IsCertInCertificateList(certs_1[0].get(), user_1_certlist_async));
+ EXPECT_FALSE(
+ IsCertInCertificateList(certs_1[0].get(), user_2_certlist_async));
- EXPECT_TRUE(IsCertInCertificateList(certs_2[0], user_2_certlist_async));
- EXPECT_FALSE(IsCertInCertificateList(certs_2[0], user_1_certlist_async));
+ EXPECT_TRUE(IsCertInCertificateList(certs_2[0].get(), user_2_certlist_async));
+ EXPECT_FALSE(
+ IsCertInCertificateList(certs_2[0].get(), user_1_certlist_async));
}
// Tests that There is no crash if the database is deleted while ListCerts
« no previous file with comments | « no previous file | net/ssl/client_cert_store_chromeos_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698