Remove implicit conversions from scoped_refptr to T* in net

net/cert/nss_cert_database_chromeos_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/cert/nss_cert_database_chromeos.h"
 
 #include "base/bind.h"
 #include "base/callback.h"
 #include "base/message_loop/message_loop_proxy.h"
 #include "base/run_loop.h"
@@ skipping 152 matching lines @@
   EXPECT_EQ(0U, failed.size());
 
   // Get cert list for each user.
   CertificateList user_1_certlist;
   CertificateList user_2_certlist;
   db_1_->ListCertsSync(&user_1_certlist);
   db_2_->ListCertsSync(&user_2_certlist);
 
   // Check that the imported certs only shows up in the list for the user that
   // imported them.
-  EXPECT_TRUE(IsCertInCertificateList(certs_1[0], user_1_certlist));
-  EXPECT_FALSE(IsCertInCertificateList(certs_1[0], user_2_certlist));
+  EXPECT_TRUE(IsCertInCertificateList(certs_1[0].get(), user_1_certlist));
+  EXPECT_FALSE(IsCertInCertificateList(certs_1[0].get(), user_2_certlist));
 
-  EXPECT_TRUE(IsCertInCertificateList(certs_2[0], user_2_certlist));
-  EXPECT_FALSE(IsCertInCertificateList(certs_2[0], user_1_certlist));
+  EXPECT_TRUE(IsCertInCertificateList(certs_2[0].get(), user_2_certlist));
+  EXPECT_FALSE(IsCertInCertificateList(certs_2[0].get(), user_1_certlist));
 
   // Run the message loop so the observer notifications get processed.
   base::RunLoop().RunUntilIdle();
   // Should have gotten two OnCACertChanged notifications.
   ASSERT_EQ(2U, added_ca_.size());
   // TODO(mattm): make NSSCertDatabase actually pass the cert to the callback,
   // and enable these checks:
   // EXPECT_EQ(certs_1[0]->os_cert_handle(), added_ca_[0]);
   // EXPECT_EQ(certs_2[0]->os_cert_handle(), added_ca_[1]);
   EXPECT_EQ(0U, added_.size());
 
   // Tests that the new certs are loaded by async ListCerts method.
   CertificateList user_1_certlist_async;
   CertificateList user_2_certlist_async;
   db_1_->ListCerts(
       base::Bind(&SwapCertLists, base::Unretained(&user_1_certlist_async)));
   db_2_->ListCerts(
       base::Bind(&SwapCertLists, base::Unretained(&user_2_certlist_async)));
 
   base::RunLoop().RunUntilIdle();
 
-  EXPECT_TRUE(IsCertInCertificateList(certs_1[0], user_1_certlist_async));
-  EXPECT_FALSE(IsCertInCertificateList(certs_1[0], user_2_certlist_async));
+  EXPECT_TRUE(IsCertInCertificateList(certs_1[0].get(), user_1_certlist_async));
+  EXPECT_FALSE(
+      IsCertInCertificateList(certs_1[0].get(), user_2_certlist_async));
 
-  EXPECT_TRUE(IsCertInCertificateList(certs_2[0], user_2_certlist_async));
-  EXPECT_FALSE(IsCertInCertificateList(certs_2[0], user_1_certlist_async));
+  EXPECT_TRUE(IsCertInCertificateList(certs_2[0].get(), user_2_certlist_async));
+  EXPECT_FALSE(
+      IsCertInCertificateList(certs_2[0].get(), user_1_certlist_async));
 }
 
 // Test that ImportServerCerts imports the cert to the correct slot, and that
 // ListCerts includes the added cert for the correct user, and does not include
 // it for the other user.
 TEST_F(NSSCertDatabaseChromeOSTest, ImportServerCert) {
   // Load test certs from disk.
   CertificateList certs_1 = CreateCertificateListFromFile(
       GetTestCertsDirectory(), "ok_cert.pem", X509Certificate::FORMAT_AUTO);
   ASSERT_EQ(1U, certs_1.size());
@@ skipping 15 matching lines @@
   EXPECT_EQ(0U, failed.size());
 
   // Get cert list for each user.
   CertificateList user_1_certlist;
   CertificateList user_2_certlist;
   db_1_->ListCertsSync(&user_1_certlist);
   db_2_->ListCertsSync(&user_2_certlist);
 
   // Check that the imported certs only shows up in the list for the user that
   // imported them.
-  EXPECT_TRUE(IsCertInCertificateList(certs_1[0], user_1_certlist));
-  EXPECT_FALSE(IsCertInCertificateList(certs_1[0], user_2_certlist));
+  EXPECT_TRUE(IsCertInCertificateList(certs_1[0].get(), user_1_certlist));
+  EXPECT_FALSE(IsCertInCertificateList(certs_1[0].get(), user_2_certlist));
 
-  EXPECT_TRUE(IsCertInCertificateList(certs_2[0], user_2_certlist));
-  EXPECT_FALSE(IsCertInCertificateList(certs_2[0], user_1_certlist));
+  EXPECT_TRUE(IsCertInCertificateList(certs_2[0].get(), user_2_certlist));
+  EXPECT_FALSE(IsCertInCertificateList(certs_2[0].get(), user_1_certlist));
 
   // Run the message loop so the observer notifications get processed.
   base::RunLoop().RunUntilIdle();
   // TODO(mattm): ImportServerCert doesn't actually cause any observers to
   // fire. Is that correct?
   EXPECT_EQ(0U, added_ca_.size());
   EXPECT_EQ(0U, added_.size());
 
   // Tests that the new certs are loaded by async ListCerts method.
   CertificateList user_1_certlist_async;
   CertificateList user_2_certlist_async;
   db_1_->ListCerts(
       base::Bind(&SwapCertLists, base::Unretained(&user_1_certlist_async)));
   db_2_->ListCerts(
       base::Bind(&SwapCertLists, base::Unretained(&user_2_certlist_async)));
 
   base::RunLoop().RunUntilIdle();
 
-  EXPECT_TRUE(IsCertInCertificateList(certs_1[0], user_1_certlist_async));
-  EXPECT_FALSE(IsCertInCertificateList(certs_1[0], user_2_certlist_async));
+  EXPECT_TRUE(IsCertInCertificateList(certs_1[0].get(), user_1_certlist_async));
+  EXPECT_FALSE(
+      IsCertInCertificateList(certs_1[0].get(), user_2_certlist_async));
 
-  EXPECT_TRUE(IsCertInCertificateList(certs_2[0], user_2_certlist_async));
-  EXPECT_FALSE(IsCertInCertificateList(certs_2[0], user_1_certlist_async));
+  EXPECT_TRUE(IsCertInCertificateList(certs_2[0].get(), user_2_certlist_async));
+  EXPECT_FALSE(
+      IsCertInCertificateList(certs_2[0].get(), user_1_certlist_async));
 }
 
 // Tests that There is no crash if the database is deleted while ListCerts
 // is being processed on the worker pool.
 TEST_F(NSSCertDatabaseChromeOSTest, NoCrashIfShutdownBeforeDoneOnWorkerPool) {
   CertificateList certlist;
   db_1_->ListCerts(base::Bind(&SwapCertLists, base::Unretained(&certlist)));
   EXPECT_EQ(0U, certlist.size());
 
   db_1_.reset();
@@ skipping 33 matching lines @@
                                      "client_2.pem",
                                      "client_2.pk8",
                                      system_db_.slot()));
   CertificateList certs;
   db_2_->ListCertsSync(&certs);
   EXPECT_TRUE(IsCertInCertificateList(cert_1.get(), certs));
   EXPECT_FALSE(IsCertInCertificateList(cert_2.get(), certs));
 }
 
 }  // namespace net