Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issue 574513003: Remove implicit conversions from scoped_refptr to T* in net (Closed)

Created:
6 years, 3 months ago by dcheng
Modified:
6 years, 3 months ago
Reviewers:
szym
CC:
cbentzel+watch_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove implicit conversions from scoped_refptr to T* in net This patch was generated by running the rewrite_scoped_refptr clang tool on a ChromeOS build. BUG=110610 Committed: https://crrev.com/36eac079abce6cd617a4ebf2ca63ff69aeaf7275 Cr-Commit-Position: refs/heads/master@{#294891}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -25 lines) Patch
M net/cert/nss_cert_database_chromeos_unittest.cc View 4 chunks +20 lines, -16 lines 0 comments Download
M net/ssl/client_cert_store_chromeos_unittest.cc View 6 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
dcheng
Some background: Unfortunately, we can't make scoped_refptr testable until the conversion operator has been removed. ...
6 years, 3 months ago (2014-09-15 20:15:10 UTC) #2
szym
lgtm
6 years, 3 months ago (2014-09-15 20:48:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/574513003/1
6 years, 3 months ago (2014-09-15 20:49:58 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as fa27801212aa0e87086650b400473c0395b7bcb2
6 years, 3 months ago (2014-09-15 21:19:57 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-15 21:25:58 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/36eac079abce6cd617a4ebf2ca63ff69aeaf7275
Cr-Commit-Position: refs/heads/master@{#294891}

Powered by Google App Engine
This is Rietveld 408576698