Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 574333003: Rename GrProgramResource to GrGpuResourceRef (Closed)

Created:
6 years, 3 months ago by bsalomon
Modified:
6 years, 3 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Rename GrProgramResource to GrGpuResourceRef BUG=skia:2889 Committed: https://skia.googlesource.com/skia/+/f96ba02513eadd9fa24d75396ec9f2d6682e464c

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address comments #

Patch Set 3 : add newline before private: #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -283 lines) Patch
M gyp/gpu.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
M include/gpu/GrGpuResource.h View 1 chunk +1 line, -1 line 0 comments Download
A + include/gpu/GrGpuResourceRef.h View 1 2 6 chunks +14 lines, -11 lines 0 comments Download
M include/gpu/GrProgramElement.h View 1 4 chunks +7 lines, -7 lines 0 comments Download
D include/gpu/GrProgramResource.h View 1 chunk +0 lines, -97 lines 0 comments Download
M include/gpu/GrTextureAccess.h View 3 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/GrDrawState.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/GrEffect.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
A + src/gpu/GrGpuResourceRef.cpp View 7 chunks +11 lines, -11 lines 0 comments Download
M src/gpu/GrProgramElement.cpp View 1 3 chunks +9 lines, -9 lines 0 comments Download
D src/gpu/GrProgramResource.cpp View 1 chunk +0 lines, -133 lines 0 comments Download
M src/gpu/GrRODrawState.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrRODrawState.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrTextureAccess.cpp View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
bsalomon
Mechanical change
6 years, 3 months ago (2014-09-17 14:34:50 UTC) #2
robertphillips
lgtm + nits https://codereview.chromium.org/574333003/diff/1/include/gpu/GrGpuResourceRef.h File include/gpu/GrGpuResourceRef.h (right): https://codereview.chromium.org/574333003/diff/1/include/gpu/GrGpuResourceRef.h#newcode86 include/gpu/GrGpuResourceRef.h:86: pending on the resource when markPendingIO ...
6 years, 3 months ago (2014-09-17 14:38:38 UTC) #3
bsalomon
https://codereview.chromium.org/574333003/diff/1/include/gpu/GrGpuResourceRef.h File include/gpu/GrGpuResourceRef.h (right): https://codereview.chromium.org/574333003/diff/1/include/gpu/GrGpuResourceRef.h#newcode86 include/gpu/GrGpuResourceRef.h:86: pending on the resource when markPendingIO is called. */ ...
6 years, 3 months ago (2014-09-17 14:55:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/574333003/40001
6 years, 3 months ago (2014-09-17 14:55:45 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-17 15:05:43 UTC) #7
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as f96ba02513eadd9fa24d75396ec9f2d6682e464c

Powered by Google App Engine
This is Rietveld 408576698