Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Unified Diff: content/public/test/browser_test_utils.cc

Issue 57433010: Prevent creating a swapped out RVH in the same SiteInstance as the current one. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: More diagnosis. Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/test/browser_test_utils.cc
diff --git a/content/public/test/browser_test_utils.cc b/content/public/test/browser_test_utils.cc
index f16b854fc707bbd9141510ca527da68ba748472c..19b5070254425810d918a92f3ee60022caff9306 100644
--- a/content/public/test/browser_test_utils.cc
+++ b/content/public/test/browser_test_utils.cc
@@ -214,9 +214,11 @@ void WaitForLoadStop(WebContents* web_contents) {
void CrashTab(WebContents* web_contents) {
RenderProcessHost* rph = web_contents->GetRenderProcessHost();
WindowedNotificationObserver observer(
- NOTIFICATION_RENDERER_PROCESS_CLOSED,
+ NOTIFICATION_RENDERER_PROCESS_TERMINATED,
ncarter (slow) 2013/11/12 03:38:26 Change this back to to NOTIFICATION_RENDERER_PROCE
Charlie Reis 2013/11/12 16:09:35 Done.
Source<RenderProcessHost>(rph));
+ LOG(INFO) << "CrashTab: Calling KillProcess.";
base::KillProcess(rph->GetHandle(), 0, false);
+ LOG(INFO) << "CrashTab: Waiting for process to exit...";
observer.Wait();
}
« content/browser/frame_host/render_view_host_manager.h ('K') | « content/browser/site_instance_impl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698