Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(955)

Unified Diff: content/browser/site_instance_impl.h

Issue 57433010: Prevent creating a swapped out RVH in the same SiteInstance as the current one. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: More diagnosis. Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/site_instance_impl.h
diff --git a/content/browser/site_instance_impl.h b/content/browser/site_instance_impl.h
index 714fee0c23b217b8a1ad0d422b0cbe53445c4e24..e7b584829a307e6f9756e4dcc2d3db5c414932d2 100644
--- a/content/browser/site_instance_impl.h
+++ b/content/browser/site_instance_impl.h
@@ -67,6 +67,15 @@ class CONTENT_EXPORT SiteInstanceImpl : public SiteInstance,
static void set_render_process_host_factory(
const RenderProcessHostFactory* rph_factory);
+ // Get the effective URL for the given actual URL. This allows the
+ // ContentBrowserClient to override the SiteInstance's site for certain URLs.
+ // For example, Chrome uses this to replace hosted app URLs with extension
+ // hosts.
+ // Only public so that we can make a consistent process swap decision in
+ // RenderViewHostManager.
+ static GURL GetEffectiveURL(BrowserContext* browser_context,
+ const GURL& url);
+
protected:
friend class BrowsingInstance;
friend class SiteInstance;
@@ -80,10 +89,6 @@ class CONTENT_EXPORT SiteInstanceImpl : public SiteInstance,
explicit SiteInstanceImpl(BrowsingInstance* browsing_instance);
private:
- // Get the effective URL for the given actual URL.
- static GURL GetEffectiveURL(BrowserContext* browser_context,
- const GURL& url);
-
// NotificationObserver implementation.
virtual void Observe(int type,
const NotificationSource& source,

Powered by Google App Engine
This is Rietveld 408576698