Prevent creating a swapped out RVH in the same SiteInstance as the current one.

content/browser/site_instance_impl.h

Index: content/browser/site_instance_impl.h
diff --git a/content/browser/site_instance_impl.h b/content/browser/site_instance_impl.h
index 714fee0c23b217b8a1ad0d422b0cbe53445c4e24..01d734350853048887df0b48d48e789a0a2f359e 100644
--- a/content/browser/site_instance_impl.h
+++ b/content/browser/site_instance_impl.h
@@ -67,6 +67,11 @@ class CONTENT_EXPORT SiteInstanceImpl : public SiteInstance,
   static void set_render_process_host_factory(
       const RenderProcessHostFactory* rph_factory);
 
+  // Get the effective URL for the given actual URL.  Public so that we can make

[nasko, 2013/11/05 18:41:00]

If this becomes external to SiteInstanceImpl, it is useful to document what
effective URL is with possibly an example.

[Charlie Reis, 2013/11/05 19:13:15]

Yeah, I wasn't thrilled about making it public, but I think it's necessary for
the process swap decisions.  I've updated the comment.

+  // a consistent process swap decision in RenderViewHostManager.
+  static GURL GetEffectiveURL(BrowserContext* browser_context,
+                              const GURL& url);
+
  protected:
   friend class BrowsingInstance;
   friend class SiteInstance;
@@ -80,10 +85,6 @@ class CONTENT_EXPORT SiteInstanceImpl : public SiteInstance,
   explicit SiteInstanceImpl(BrowsingInstance* browsing_instance);
 
  private:
-  // Get the effective URL for the given actual URL.
-  static GURL GetEffectiveURL(BrowserContext* browser_context,
-                              const GURL& url);
-
   // NotificationObserver implementation.
   virtual void Observe(int type,
                        const NotificationSource& source,