Prevent creating a swapped out RVH in the same SiteInstance as the current one.

content/browser/site_instance_impl.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_SITE_INSTANCE_IMPL_H_
 #define CONTENT_BROWSER_SITE_INSTANCE_IMPL_H_
 
 #include "content/browser/renderer_host/render_process_host_impl.h"
 #include "content/common/content_export.h"
 #include "content/public/browser/notification_observer.h"
@@ skipping 49 matching lines @@
   // discarded to save memory.
   size_t active_view_count() { return active_view_count_; }
 
   // Sets the global factory used to create new RenderProcessHosts.  It may be
   // NULL, in which case the default BrowserRenderProcessHost will be created
   // (this is the behavior if you don't call this function).  The factory must
   // be set back to NULL before it's destroyed; ownership is not transferred.
   static void set_render_process_host_factory(
       const RenderProcessHostFactory* rph_factory);
 
+  // Get the effective URL for the given actual URL.  Public so that we can make

[nasko, 2013/11/05 18:41:00]

If this becomes external to SiteInstanceImpl, it is useful to document what
effective URL is with possibly an example.

[Charlie Reis, 2013/11/05 19:13:15]

Yeah, I wasn't thrilled about making it public, but I think it's necessary for
the process swap decisions.  I've updated the comment.

+  // a consistent process swap decision in RenderViewHostManager.
+  static GURL GetEffectiveURL(BrowserContext* browser_context,
+                              const GURL& url);
+
  protected:
   friend class BrowsingInstance;
   friend class SiteInstance;
 
   // Virtual to allow tests to extend it.
   virtual ~SiteInstanceImpl();
 
   // Create a new SiteInstance.  Protected to give access to BrowsingInstance
   // and tests; most callers should use Create or GetRelatedSiteInstance
   // instead.
   explicit SiteInstanceImpl(BrowsingInstance* browsing_instance);
 
  private:
-  // Get the effective URL for the given actual URL.
-  static GURL GetEffectiveURL(BrowserContext* browser_context,
-                              const GURL& url);
-
   // NotificationObserver implementation.
   virtual void Observe(int type,
                        const NotificationSource& source,
                        const NotificationDetails& details) OVERRIDE;
 
   // Used to restrict a process' origin access rights.
   void LockToOrigin();
 
   // An object used to construct RenderProcessHosts.
   static const RenderProcessHostFactory* g_render_process_host_factory_;
@@ skipping 27 matching lines @@
 
   // Whether SetSite has been called.
   bool has_site_;
 
   DISALLOW_COPY_AND_ASSIGN(SiteInstanceImpl);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_SITE_INSTANCE_IMPL_H_