Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1254)

Issue 57433010: Prevent creating a swapped out RVH in the same SiteInstance as the current one. (Closed)

Created:
7 years, 1 month ago by Charlie Reis
Modified:
7 years, 1 month ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, creis+watch_chromium.org, ajwong+watch_chromium.org
Visibility:
Public.

Description

Prevent creating a swapped out RVH in the same SiteInstance as the current one. BUG=123007, 319613 TEST=RenderViewHostManagerTest.CleanUpSwappedOutRVHOnProcessCrash Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=235953

Patch Set 1 : Initial patch #

Patch Set 2 : Enforce force_swap #

Patch Set 3 : Fix tests #

Patch Set 4 : Fix flakiness. #

Patch Set 5 : Rebase #

Total comments: 4

Patch Set 6 : Fix comments from Nasko #

Patch Set 7 : Diagnose timeout. #

Patch Set 8 : More diagnosis. #

Total comments: 8

Patch Set 9 : Rebase #

Patch Set 10 : Apply Nick's changes #

Patch Set 11 : Disable tests (319613) #

Patch Set 12 : Rebase #

Patch Set 13 : Rebase again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -58 lines) Patch
M chrome/browser/apps/app_window_browsertest.cc View 1 2 3 4 5 6 7 8 9 10 1 chunk +11 lines, -8 lines 0 comments Download
M chrome/browser/extensions/api/management/management_api_browsertest.cc View 1 2 3 4 5 6 7 8 9 3 chunks +10 lines, -8 lines 0 comments Download
M content/browser/frame_host/render_view_host_manager.h View 1 2 3 4 5 6 7 8 9 2 chunks +5 lines, -3 lines 0 comments Download
M content/browser/frame_host/render_view_host_manager.cc View 1 2 3 4 5 6 7 8 5 chunks +53 lines, -31 lines 0 comments Download
M content/browser/frame_host/render_view_host_manager_unittest.cc View 1 2 3 4 5 6 7 8 3 chunks +10 lines, -4 lines 0 comments Download
M content/browser/site_instance_impl.h View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +9 lines, -4 lines 0 comments Download

Messages

Total messages: 18 (0 generated)
Charlie Reis
Another white whale. This is the key part of http://crbug.com/123007, which I've tried several times ...
7 years, 1 month ago (2013-11-05 17:55:38 UTC) #1
nasko
Couple of clarifying comments. https://codereview.chromium.org/57433010/diff/320001/content/browser/frame_host/render_view_host_manager.cc File content/browser/frame_host/render_view_host_manager.cc (right): https://codereview.chromium.org/57433010/diff/320001/content/browser/frame_host/render_view_host_manager.cc#newcode574 content/browser/frame_host/render_view_host_manager.cc:574: // BrowsingInstance to be different ...
7 years, 1 month ago (2013-11-05 18:41:00 UTC) #2
Charlie Reis
Thanks. New patch uploaded. https://codereview.chromium.org/57433010/diff/320001/content/browser/frame_host/render_view_host_manager.cc File content/browser/frame_host/render_view_host_manager.cc (right): https://codereview.chromium.org/57433010/diff/320001/content/browser/frame_host/render_view_host_manager.cc#newcode574 content/browser/frame_host/render_view_host_manager.cc:574: // BrowsingInstance to be different ...
7 years, 1 month ago (2013-11-05 19:13:15 UTC) #3
nasko
LGTM
7 years, 1 month ago (2013-11-05 19:15:23 UTC) #4
ncarter (slow)
Here's how to get this working on Windows. I've implemented these suggestions in https://codereview.chromium.org/62523004/ which ...
7 years, 1 month ago (2013-11-12 03:38:25 UTC) #5
Charlie Reis
Fantastic-- thanks a ton for the diagnosis, Nick! The SetEnabled test does appear to be ...
7 years, 1 month ago (2013-11-12 16:09:35 UTC) #6
Matt Perry
lgtm
7 years, 1 month ago (2013-11-12 19:48:15 UTC) #7
Charlie Reis
[+benwells, CC mlamouri] Ben, can I take you up on the suggestion to disable the ...
7 years, 1 month ago (2013-11-15 18:26:40 UTC) #8
mlamouri (slow - plz ping)
You mentioned that you saw that problem only on Mac and locally on Linux. Is ...
7 years, 1 month ago (2013-11-18 04:23:02 UTC) #9
Charlie Reis
On 2013/11/18 04:23:02, Mounir Lamouri wrote: > You mentioned that you saw that problem only ...
7 years, 1 month ago (2013-11-18 18:05:56 UTC) #10
Charlie Reis
On 2013/11/18 18:05:56, creis wrote: > On 2013/11/18 04:23:02, Mounir Lamouri wrote: > > You ...
7 years, 1 month ago (2013-11-18 19:59:31 UTC) #11
benwells
lgtm. Sorry about the delay, we were hoping to keep these enabled on some platforms.
7 years, 1 month ago (2013-11-19 02:21:37 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/creis@chromium.org/57433010/760001
7 years, 1 month ago (2013-11-19 02:37:13 UTC) #13
commit-bot: I haz the power
Failed to apply patch for content/browser/site_instance_impl.h: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 1 month ago (2013-11-19 02:37:19 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/creis@chromium.org/57433010/1000001
7 years, 1 month ago (2013-11-19 02:47:18 UTC) #15
commit-bot: I haz the power
Failed to apply patch for content/browser/site_instance_impl.h: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 1 month ago (2013-11-19 02:47:23 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/creis@chromium.org/57433010/990007
7 years, 1 month ago (2013-11-19 02:51:31 UTC) #17
commit-bot: I haz the power
7 years, 1 month ago (2013-11-19 09:50:34 UTC) #18
Message was sent while issue was closed.
Change committed as 235953

Powered by Google App Engine
This is Rietveld 408576698