Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 574133002: Add initial integrated assembler w/ some Xmm ops. (Closed)

Created:
6 years, 3 months ago by jvoung (off chromium)
Modified:
6 years, 3 months ago
Reviewers:
Jim Stichnoth
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Visibility:
Public.

Description

Add initial integrated assembler w/ some Xmm ops. Add a flag to use the integrated assembler. Handle simple XMM binary op instructions as an initial example of how instructions might be handled. This tests fixups in a very limited sense -- Track buffer locations of fixups for floating point immediates. Patchset one shows the original dart assembler code (revision 39313), so that it can be diffed. BUG=none R=stichnot@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=8acded039857a42b170c1cbc0ad4d1345419de3c

Patch Set 1 #

Patch Set 2 : first diff #

Patch Set 3 : tighter code (fewer params), more const data #

Patch Set 4 : Use templates #

Patch Set 5 : more cleanup #

Total comments: 6

Patch Set 6 : review #

Patch Set 7 : review #

Patch Set 8 : formatting #

Patch Set 9 : remove leftover specialization #

Patch Set 10 : remove duplicate pxor, and use enum #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3594 lines, -88 lines) Patch
M Makefile.standalone View 1 3 4 2 chunks +3 lines, -0 lines 0 comments Download
M src/IceCfg.h View 1 2 3 4 5 6 3 chunks +10 lines, -0 lines 0 comments Download
M src/IceCfg.cpp View 1 2 3 4 5 6 1 chunk +4 lines, -1 line 0 comments Download
M src/IceCfgNode.cpp View 1 2 3 4 5 6 1 chunk +5 lines, -1 line 0 comments Download
M src/IceClFlags.h View 1 2 1 chunk +4 lines, -2 lines 0 comments Download
M src/IceDefs.h View 1 2 3 4 5 6 1 chunk +0 lines, -5 lines 0 comments Download
A src/IceFixups.h View 1 1 chunk +32 lines, -0 lines 0 comments Download
M src/IceInst.h View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M src/IceInst.cpp View 1 2 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M src/IceInstX8632.h View 1 2 3 4 5 6 13 chunks +111 lines, -16 lines 0 comments Download
M src/IceInstX8632.cpp View 1 2 3 4 5 6 7 8 11 chunks +233 lines, -0 lines 0 comments Download
A src/IceMemoryRegion.h View 1 1 chunk +93 lines, -0 lines 0 comments Download
A src/IceMemoryRegion.cpp View 1 2 3 4 5 1 chunk +32 lines, -0 lines 0 comments Download
M src/IceRegistersX8632.h View 1 2 3 4 1 chunk +43 lines, -39 lines 0 comments Download
M src/IceTargetLowering.h View 1 2 3 4 5 6 2 chunks +3 lines, -0 lines 0 comments Download
M src/IceTargetLowering.cpp View 1 2 3 4 5 6 2 chunks +10 lines, -0 lines 0 comments Download
M src/IceTargetLoweringX8632.h View 1 2 3 4 5 6 2 chunks +2 lines, -0 lines 0 comments Download
M src/IceTargetLoweringX8632.cpp View 1 2 3 4 5 6 3 chunks +10 lines, -1 line 0 comments Download
A src/IceUtils.h View 1 2 3 4 5 6 7 1 chunk +59 lines, -0 lines 0 comments Download
A src/assembler.h View 1 2 1 chunk +222 lines, -0 lines 0 comments Download
A src/assembler.cpp View 1 1 chunk +129 lines, -0 lines 0 comments Download
A src/assembler_ia32.h View 1 2 3 4 5 6 7 8 9 1 chunk +724 lines, -0 lines 0 comments Download
A src/assembler_ia32.cpp View 1 2 3 4 5 6 7 8 9 1 chunk +1822 lines, -0 lines 0 comments Download
M src/llvm2ice.cpp View 1 2 3 4 5 6 7 8 9 2 chunks +6 lines, -0 lines 0 comments Download
M tests_lit/llvm2ice_tests/align-spill-locations.ll View 1 2 3 4 5 6 4 chunks +10 lines, -6 lines 0 comments Download
M tests_lit/llvm2ice_tests/ebp_args.ll View 1 2 chunks +16 lines, -14 lines 0 comments Download
M tests_lit/llvm2ice_tests/nop-insertion.ll View 1 1 chunk +8 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
jvoung (off chromium)
Okay, this should be cleaner and more focused than the other CL I sent out ...
6 years, 3 months ago (2014-09-20 18:13:35 UTC) #4
Jim Stichnoth
LGTM. https://codereview.chromium.org/574133002/diff/120001/src/IceInstX8632.cpp File src/IceInstX8632.cpp (right): https://codereview.chromium.org/574133002/diff/120001/src/IceInstX8632.cpp#newcode490 src/IceInstX8632.cpp:490: (Asm->*(Emitter.XmmXmm))(Ty, VarReg, SrcReg); My head is exploding trying ...
6 years, 3 months ago (2014-09-22 21:58:13 UTC) #5
jvoung (off chromium)
Thanks! https://codereview.chromium.org/574133002/diff/120001/src/IceInstX8632.cpp File src/IceInstX8632.cpp (right): https://codereview.chromium.org/574133002/diff/120001/src/IceInstX8632.cpp#newcode490 src/IceInstX8632.cpp:490: (Asm->*(Emitter.XmmXmm))(Ty, VarReg, SrcReg); On 2014/09/22 21:58:13, stichnot wrote: ...
6 years, 3 months ago (2014-09-23 00:26:16 UTC) #6
jvoung (off chromium)
6 years, 3 months ago (2014-09-23 01:02:35 UTC) #7
Message was sent while issue was closed.
Committed patchset #10 (id:220001) manually as 8acded0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698