Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 574103002: Remove guava from chromium. (Closed)

Created:
6 years, 3 months ago by nyquist
Modified:
6 years, 3 months ago
Reviewers:
cjhopman, brettw
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove guava from chromium. This removes the rest of guava from a chromium checkout. It also removes a workaround in build/android/gyp/javac.py which sorts input files for javac. The issue was fixed in guava 14 (https://code.google.com/p/guava-libraries/issues/detail?id=950), but it was never rolled in to chromium. The last remaining files in third_party/guava are left because some bots do not delete non-existing DEPS. COPYING is a copy of the current version of the COPYING file from the guava repository. See http://crbug.com/380688 for details about the DEPS issue. BUG=412673 Committed: https://crrev.com/e1aebb5900838ff7c3e83dd54b4e51e88f866f04 Cr-Commit-Position: refs/heads/master@{#296202}

Patch Set 1 #

Patch Set 2 : Keep README.chromium and add COPYING from guava repo. #

Total comments: 1

Patch Set 3 : Add back OWNERS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -480 lines) Patch
M .gitignore View 1 chunk +0 lines, -1 line 0 comments Download
M BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download
M DEPS View 1 1 chunk +0 lines, -3 lines 0 comments Download
M build/android/gyp/javac.py View 1 chunk +0 lines, -7 lines 0 comments Download
D third_party/guava/BUILD.gn View 1 chunk +0 lines, -406 lines 0 comments Download
A + third_party/guava/COPYING View 1 0 chunks +-1 lines, --1 lines 0 comments Download
D third_party/guava/README.chromium View 1 1 chunk +12 lines, -5 lines 0 comments Download
D third_party/guava/guava.gyp View 1 chunk +0 lines, -21 lines 0 comments Download
D third_party/guava/proguard.flags View 1 chunk +0 lines, -37 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
nyquist
cjhopman: PTAL
6 years, 3 months ago (2014-09-22 21:27:06 UTC) #2
cjhopman
lgtm https://codereview.chromium.org/574103002/diff/20001/third_party/guava/OWNERS File third_party/guava/OWNERS (left): https://codereview.chromium.org/574103002/diff/20001/third_party/guava/OWNERS#oldcode1 third_party/guava/OWNERS:1: nyquist@chromium.org I would keep the OWNERS file.
6 years, 3 months ago (2014-09-22 21:50:35 UTC) #3
nyquist
brettw: OWNERS for //BUILD.gn The target is not in use anymore, so removing it from ...
6 years, 3 months ago (2014-09-22 23:41:57 UTC) #5
brettw
lgtm
6 years, 3 months ago (2014-09-23 03:08:47 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/574103002/40001
6 years, 3 months ago (2014-09-23 16:34:44 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001) as a3ab7c9dcfb7eb6ac38548c667b752bd1a5d1ffb
6 years, 3 months ago (2014-09-23 16:40:51 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-23 16:41:42 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/e1aebb5900838ff7c3e83dd54b4e51e88f866f04
Cr-Commit-Position: refs/heads/master@{#296202}

Powered by Google App Engine
This is Rietveld 408576698