Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: build/android/gyp/javac.py

Issue 574103002: Remove guava from chromium. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add back OWNERS Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « DEPS ('k') | third_party/guava/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/gyp/javac.py
diff --git a/build/android/gyp/javac.py b/build/android/gyp/javac.py
index dcbc48b0fc489f8ee9a8120edf2993973360ce84..eccee95b68803880d83197d83f9d74d8f42714c5 100755
--- a/build/android/gyp/javac.py
+++ b/build/android/gyp/javac.py
@@ -62,13 +62,6 @@ def DoJavac(
checking will be enabled.
"""
- # Compiling guava with certain orderings of input files causes a compiler
- # crash... Sorted order works, so use that.
- # See https://code.google.com/p/guava-libraries/issues/detail?id=950
- # TODO(cjhopman): Remove this when we have update guava or the compiler to a
- # version without this problem.
- java_files.sort()
-
jar_inputs = []
for path in classpath:
if os.path.exists(path + '.TOC'):
« no previous file with comments | « DEPS ('k') | third_party/guava/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698