Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Issue 573893004: Remove some unused proxy-related histograms. (Closed)

Created:
6 years, 3 months ago by eroman
Modified:
6 years, 3 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove some unused proxy-related histograms. These histograms are no longer being monitored, so removing them from Chromium. - Net.DhcpWpad* - Net.MTPR_* - Net.ProxyResolver* - Net.ProxyPollConfigurationTime [1] - Net.GetProxyForURL*: [1] [1] Removed from histograms.xml; the histogram is not present in the code. Committed: https://crrev.com/7f1ac491eb1c33fb7a22dce12fe01551ae2d8475 Cr-Commit-Position: refs/heads/master@{#295105}

Patch Set 1 : #

Patch Set 2 : Add back 3 deprecated histograms #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -236 lines) Patch
M net/proxy/dhcp_proxy_script_adapter_fetcher_win.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M net/proxy/dhcp_proxy_script_fetcher_win.cc View 7 chunks +0 lines, -41 lines 0 comments Download
M net/proxy/multi_threaded_proxy_resolver.cc View 6 chunks +0 lines, -22 lines 0 comments Download
M net/proxy/proxy_resolver_v8_tracing.cc View 18 chunks +1 line, -171 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 34 chunks +102 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
eroman
@ellyjones: for the net code changes @isherman: for histograms.xml (Is it recommended to delete old ...
6 years, 3 months ago (2014-09-15 23:35:29 UTC) #3
Ilya Sherman
Please mark all of the removed histograms as <obsolete> rather than deleting them.
6 years, 3 months ago (2014-09-15 23:39:59 UTC) #4
eroman
Done. There are 3 for which I do not know the history, so I marked ...
6 years, 3 months ago (2014-09-15 23:54:36 UTC) #5
Ilya Sherman
Thanks. Histograms LGTM.
6 years, 3 months ago (2014-09-16 00:00:54 UTC) #6
Elly Fong-Jones
On 2014/09/16 00:00:54, Ilya Sherman wrote: > Thanks. Histograms LGTM. network code lgtm
6 years, 3 months ago (2014-09-16 14:56:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/573893004/40001
6 years, 3 months ago (2014-09-16 17:28:32 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:40001) as 0b3bd4f871d17cc4323859411dcc0c0bc28da862
6 years, 3 months ago (2014-09-16 18:26:43 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-16 18:28:54 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7f1ac491eb1c33fb7a22dce12fe01551ae2d8475
Cr-Commit-Position: refs/heads/master@{#295105}

Powered by Google App Engine
This is Rietveld 408576698