net/proxy/dhcp_proxy_script_adapter_fetcher_win.cc - Issue 573893004: Remove some unused proxy-related histograms.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/proxy/dhcp_proxy_script_adapter_fetcher_win.cc

Issue 573893004: Remove some unused proxy-related histograms. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add back 3 deprecated histograms Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/proxy/dhcp_proxy_script_adapter_fetcher_win.cc

diff --git a/net/proxy/dhcp_proxy_script_adapter_fetcher_win.cc b/net/proxy/dhcp_proxy_script_adapter_fetcher_win.cc

index 199014f8beccd075bf303a43f85daa24438fda42..b50b57930ddfd0501d0fcdd39d3d93a9f27a8a50 100644

--- a/net/proxy/dhcp_proxy_script_adapter_fetcher_win.cc

+++ b/net/proxy/dhcp_proxy_script_adapter_fetcher_win.cc

@@ -8,7 +8,6 @@

#include "base/bind_helpers.h"

#include "base/logging.h"

#include "base/message_loop/message_loop_proxy.h"

-#include "base/metrics/histogram.h"

#include "base/strings/string_util.h"

#include "base/strings/sys_string_conversions.h"

#include "base/task_runner.h"

@@ -262,7 +261,6 @@ std::string DhcpProxyScriptAdapterFetcher::GetPacURLFromDhcp(

if (res != NO_ERROR) {

VLOG(1) << "Error fetching PAC URL from DHCP: " << res;

- UMA_HISTOGRAM_COUNTS("Net.DhcpWpadUnhandledDhcpError", 1);

} else if (wpad_params.nBytesData) {

return SanitizeDhcpApiString(

reinterpret_cast<const char*>(wpad_params.Data),

« no previous file with comments | « no previous file | net/proxy/dhcp_proxy_script_fetcher_win.cc » ('j') | no next file with comments »