Eliminate NOTIFICATION_HISTORY_LOADED notification

chrome/browser/history/history_service.h

Index: chrome/browser/history/history_service.h
diff --git a/chrome/browser/history/history_service.h b/chrome/browser/history/history_service.h
index 7e7eb103e0468bed4e8d3ea3f8b66bb75fba5600..8e87359a71c700f198fc892b7edc4f64b664ec82 100644
--- a/chrome/browser/history/history_service.h
+++ b/chrome/browser/history/history_service.h
@@ -53,6 +53,10 @@ class FilePath;
 class Thread;
 }
 
+namespace safe_browsing {
+class LastDownloadFinder;
+}
+
 namespace visitedlink {
 class VisitedLinkMaster;
 }
@@ -539,8 +543,10 @@ class HistoryService : public content::NotificationObserver,
   friend class HistoryURLProviderTest;
   friend class history::InMemoryURLIndexTest;
   template<typename Info, typename Callback> friend class DownloadRequest;
+  friend class safe_browsing::LastDownloadFinder;
   friend class PageUsageRequest;
   friend class RedirectRequest;
+  friend class SyncBookmarkDataTypeControllerTest;
   friend class TestingProfile;
 
   // Called on shutdown, this will tell the history backend to complete and
@@ -603,6 +609,10 @@ class HistoryService : public content::NotificationObserver,
                         const history::RedirectList& redirects,
                         base::Time visit_time);
 
+  // Notify all HistoryServiceObservers registered that the
+  // HistoryService has finished loading.
+  void NotifyHistoryServiceLoaded();
+
   // Favicon -------------------------------------------------------------------
 
   // These favicon methods are exposed to the FaviconService. Instead of calling
@@ -841,6 +851,9 @@ class HistoryService : public content::NotificationObserver,
                                       a, b, c, d, e));
   }
 
+  // TODO(sdefresne): remove this method.

[sdefresne, 2014/11/04 14:12:29]

nit: add reference to http://crbug.com/430070 (I just created it, sorry).

[nshaik, 2014/11/04 21:20:27]

Done.

+  Profile* profile() { return profile_; }
+
   base::ThreadChecker thread_checker_;
 
   content::NotificationRegistrar registrar_;