Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Unified Diff: chrome/test/base/ui_test_utils.h

Issue 573553004: Eliminate NOTIFICATION_HISTORY_LOADED notification (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/base/ui_test_utils.h
diff --git a/chrome/test/base/ui_test_utils.h b/chrome/test/base/ui_test_utils.h
index 9e690d1534ad604a9efc066ee396884e928eba93..57a1d7019246a5bfc4af212fae87581a999a556c 100644
--- a/chrome/test/base/ui_test_utils.h
+++ b/chrome/test/base/ui_test_utils.h
@@ -306,6 +306,19 @@ class HistoryEnumerator {
DISALLOW_COPY_AND_ASSIGN(HistoryEnumerator);
};
+// Wait for HistoryService to load.
sdefresne 2014/09/23 08:45:10 You can move this class in ui_test_utils.cc since
nshaik 2014/10/29 08:43:39 Done.
+class WaitHistoryLoadedObserver : public history::HistoryServiceObserver {
+ public:
+ explicit WaitHistoryLoadedObserver(content::MessageLoopRunner* runner);
+ // Is called when |service| is loaded.
sdefresne 2014/10/20 13:15:43 // history::HistoryServiceObserver:
+ virtual void HistoryServiceLoaded(HistoryService* service) OVERRIDE;
sdefresne 2014/10/20 13:15:43 OVERRIDE -> override
+ virtual ~WaitHistoryLoadedObserver();
sdefresne 2014/10/20 13:15:43 Move the destructor with the constructor.
+
+ private:
+ // weak
+ content::MessageLoopRunner* runner_;
+};
+
} // namespace ui_test_utils
#endif // CHROME_TEST_BASE_UI_TEST_UTILS_H_

Powered by Google App Engine
This is Rietveld 408576698