Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Unified Diff: components/metrics/test_metrics_service_client.h

Issue 573403002: Change UMA proto product field to be an int32. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments and add a couple of tests. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/metrics/test_metrics_service_client.h
diff --git a/components/metrics/test_metrics_service_client.h b/components/metrics/test_metrics_service_client.h
index edbee2fe419285a04d7ab431eed8868b80aa7f6d..43600df161f14f0ba4c308a19e42cda1a6f91165 100644
--- a/components/metrics/test_metrics_service_client.h
+++ b/components/metrics/test_metrics_service_client.h
@@ -23,6 +23,7 @@ class TestMetricsServiceClient : public MetricsServiceClient {
// MetricsServiceClient:
virtual void SetMetricsClientId(const std::string& client_id) OVERRIDE;
virtual bool IsOffTheRecordSessionActive() OVERRIDE;
+ virtual int32_t GetProduct() OVERRIDE;
virtual std::string GetApplicationLocale() OVERRIDE;
virtual bool GetBrand(std::string* brand_code) OVERRIDE;
virtual SystemProfileProto::Channel GetChannel() OVERRIDE;
@@ -39,10 +40,12 @@ class TestMetricsServiceClient : public MetricsServiceClient {
const std::string& get_client_id() const { return client_id_; }
void set_version_string(const std::string& str) { version_string_ = str; }
+ void set_product(int32_t product) { product_ = product; }
private:
std::string client_id_;
std::string version_string_;
+ int32_t product_;
DISALLOW_COPY_AND_ASSIGN(TestMetricsServiceClient);
};
« no previous file with comments | « components/metrics/proto/chrome_user_metrics_extension.proto ('k') | components/metrics/test_metrics_service_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698