Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Side by Side Diff: components/metrics/test_metrics_service_client.h

Issue 573403002: Change UMA proto product field to be an int32. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments and add a couple of tests. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_METRICS_TEST_METRICS_SERVICE_CLIENT_H_ 5 #ifndef COMPONENTS_METRICS_TEST_METRICS_SERVICE_CLIENT_H_
6 #define COMPONENTS_METRICS_TEST_METRICS_SERVICE_CLIENT_H_ 6 #define COMPONENTS_METRICS_TEST_METRICS_SERVICE_CLIENT_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "components/metrics/metrics_service_client.h" 10 #include "components/metrics/metrics_service_client.h"
11 11
12 namespace metrics { 12 namespace metrics {
13 13
14 // A simple concrete implementation of the MetricsServiceClient interface, for 14 // A simple concrete implementation of the MetricsServiceClient interface, for
15 // use in tests. 15 // use in tests.
16 class TestMetricsServiceClient : public MetricsServiceClient { 16 class TestMetricsServiceClient : public MetricsServiceClient {
17 public: 17 public:
18 static const char kBrandForTesting[]; 18 static const char kBrandForTesting[];
19 19
20 TestMetricsServiceClient(); 20 TestMetricsServiceClient();
21 virtual ~TestMetricsServiceClient(); 21 virtual ~TestMetricsServiceClient();
22 22
23 // MetricsServiceClient: 23 // MetricsServiceClient:
24 virtual void SetMetricsClientId(const std::string& client_id) OVERRIDE; 24 virtual void SetMetricsClientId(const std::string& client_id) OVERRIDE;
25 virtual bool IsOffTheRecordSessionActive() OVERRIDE; 25 virtual bool IsOffTheRecordSessionActive() OVERRIDE;
26 virtual int32_t GetProduct() OVERRIDE;
26 virtual std::string GetApplicationLocale() OVERRIDE; 27 virtual std::string GetApplicationLocale() OVERRIDE;
27 virtual bool GetBrand(std::string* brand_code) OVERRIDE; 28 virtual bool GetBrand(std::string* brand_code) OVERRIDE;
28 virtual SystemProfileProto::Channel GetChannel() OVERRIDE; 29 virtual SystemProfileProto::Channel GetChannel() OVERRIDE;
29 virtual std::string GetVersionString() OVERRIDE; 30 virtual std::string GetVersionString() OVERRIDE;
30 virtual void OnLogUploadComplete() OVERRIDE; 31 virtual void OnLogUploadComplete() OVERRIDE;
31 virtual void StartGatheringMetrics( 32 virtual void StartGatheringMetrics(
32 const base::Closure& done_callback) OVERRIDE; 33 const base::Closure& done_callback) OVERRIDE;
33 virtual void CollectFinalMetrics(const base::Closure& done_callback) 34 virtual void CollectFinalMetrics(const base::Closure& done_callback)
34 OVERRIDE; 35 OVERRIDE;
35 virtual scoped_ptr<MetricsLogUploader> CreateUploader( 36 virtual scoped_ptr<MetricsLogUploader> CreateUploader(
36 const std::string& server_url, 37 const std::string& server_url,
37 const std::string& mime_type, 38 const std::string& mime_type,
38 const base::Callback<void(int)>& on_upload_complete) OVERRIDE; 39 const base::Callback<void(int)>& on_upload_complete) OVERRIDE;
39 40
40 const std::string& get_client_id() const { return client_id_; } 41 const std::string& get_client_id() const { return client_id_; }
41 void set_version_string(const std::string& str) { version_string_ = str; } 42 void set_version_string(const std::string& str) { version_string_ = str; }
43 void set_product(int32_t product) { product_ = product; }
42 44
43 private: 45 private:
44 std::string client_id_; 46 std::string client_id_;
45 std::string version_string_; 47 std::string version_string_;
48 int32_t product_;
46 49
47 DISALLOW_COPY_AND_ASSIGN(TestMetricsServiceClient); 50 DISALLOW_COPY_AND_ASSIGN(TestMetricsServiceClient);
48 }; 51 };
49 52
50 } // namespace metrics 53 } // namespace metrics
51 54
52 #endif // COMPONENTS_METRICS_TEST_METRICS_SERVICE_CLIENT_H_ 55 #endif // COMPONENTS_METRICS_TEST_METRICS_SERVICE_CLIENT_H_
OLDNEW
« no previous file with comments | « components/metrics/proto/chrome_user_metrics_extension.proto ('k') | components/metrics/test_metrics_service_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698