chrome/browser/metrics/chrome_metrics_service_client.h - Issue 573403002: Change UMA proto product field to be an int32.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/metrics/chrome_metrics_service_client.h

Issue 573403002: Change UMA proto product field to be an int32. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments and add a couple of tests. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/metrics/chrome_metrics_service_client.h

diff --git a/chrome/browser/metrics/chrome_metrics_service_client.h b/chrome/browser/metrics/chrome_metrics_service_client.h

index 1cb9f4536466cad07ccc362a12cb42e3950f5bdb..6f2f251af45aa6a7560e034a66451b86a29fa8e3 100644

--- a/chrome/browser/metrics/chrome_metrics_service_client.h

+++ b/chrome/browser/metrics/chrome_metrics_service_client.h

@@ -58,6 +58,7 @@ class ChromeMetricsServiceClient

// metrics::MetricsServiceClient:

virtual void SetMetricsClientId(const std::string& client_id) OVERRIDE;

virtual bool IsOffTheRecordSessionActive() OVERRIDE;

+ virtual int32 GetProduct() OVERRIDE;

virtual std::string GetApplicationLocale() OVERRIDE;

virtual bool GetBrand(std::string* brand_code) OVERRIDE;

virtual metrics::SystemProfileProto::Channel GetChannel() OVERRIDE;

« no previous file with comments | « no previous file | chrome/browser/metrics/chrome_metrics_service_client.cc » ('j') | no next file with comments »