Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Side by Side Diff: chrome/browser/metrics/chrome_metrics_service_client.h

Issue 573403002: Change UMA proto product field to be an int32. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments and add a couple of tests. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/metrics/chrome_metrics_service_client.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_METRICS_CHROME_METRICS_SERVICE_CLIENT_H_ 5 #ifndef CHROME_BROWSER_METRICS_CHROME_METRICS_SERVICE_CLIENT_H_
6 #define CHROME_BROWSER_METRICS_CHROME_METRICS_SERVICE_CLIENT_H_ 6 #define CHROME_BROWSER_METRICS_CHROME_METRICS_SERVICE_CLIENT_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/basictypes.h" 10 #include "base/basictypes.h"
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
51 static scoped_ptr<ChromeMetricsServiceClient> Create( 51 static scoped_ptr<ChromeMetricsServiceClient> Create(
52 metrics::MetricsStateManager* state_manager, 52 metrics::MetricsStateManager* state_manager,
53 PrefService* local_state); 53 PrefService* local_state);
54 54
55 // Registers local state prefs used by this class. 55 // Registers local state prefs used by this class.
56 static void RegisterPrefs(PrefRegistrySimple* registry); 56 static void RegisterPrefs(PrefRegistrySimple* registry);
57 57
58 // metrics::MetricsServiceClient: 58 // metrics::MetricsServiceClient:
59 virtual void SetMetricsClientId(const std::string& client_id) OVERRIDE; 59 virtual void SetMetricsClientId(const std::string& client_id) OVERRIDE;
60 virtual bool IsOffTheRecordSessionActive() OVERRIDE; 60 virtual bool IsOffTheRecordSessionActive() OVERRIDE;
61 virtual int32 GetProduct() OVERRIDE;
61 virtual std::string GetApplicationLocale() OVERRIDE; 62 virtual std::string GetApplicationLocale() OVERRIDE;
62 virtual bool GetBrand(std::string* brand_code) OVERRIDE; 63 virtual bool GetBrand(std::string* brand_code) OVERRIDE;
63 virtual metrics::SystemProfileProto::Channel GetChannel() OVERRIDE; 64 virtual metrics::SystemProfileProto::Channel GetChannel() OVERRIDE;
64 virtual std::string GetVersionString() OVERRIDE; 65 virtual std::string GetVersionString() OVERRIDE;
65 virtual void OnLogUploadComplete() OVERRIDE; 66 virtual void OnLogUploadComplete() OVERRIDE;
66 virtual void StartGatheringMetrics( 67 virtual void StartGatheringMetrics(
67 const base::Closure& done_callback) OVERRIDE; 68 const base::Closure& done_callback) OVERRIDE;
68 virtual void CollectFinalMetrics(const base::Closure& done_callback) 69 virtual void CollectFinalMetrics(const base::Closure& done_callback)
69 OVERRIDE; 70 OVERRIDE;
70 virtual scoped_ptr<metrics::MetricsLogUploader> CreateUploader( 71 virtual scoped_ptr<metrics::MetricsLogUploader> CreateUploader(
(...skipping 108 matching lines...) Expand 10 before | Expand all | Expand 10 after
179 // The MemoryGrowthTracker instance that tracks memory usage growth in 180 // The MemoryGrowthTracker instance that tracks memory usage growth in
180 // MemoryDetails. 181 // MemoryDetails.
181 MemoryGrowthTracker memory_growth_tracker_; 182 MemoryGrowthTracker memory_growth_tracker_;
182 183
183 base::WeakPtrFactory<ChromeMetricsServiceClient> weak_ptr_factory_; 184 base::WeakPtrFactory<ChromeMetricsServiceClient> weak_ptr_factory_;
184 185
185 DISALLOW_COPY_AND_ASSIGN(ChromeMetricsServiceClient); 186 DISALLOW_COPY_AND_ASSIGN(ChromeMetricsServiceClient);
186 }; 187 };
187 188
188 #endif // CHROME_BROWSER_METRICS_CHROME_METRICS_SERVICE_CLIENT_H_ 189 #endif // CHROME_BROWSER_METRICS_CHROME_METRICS_SERVICE_CLIENT_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/metrics/chrome_metrics_service_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698