Issue 573273002: Binary Size tool: Check DWARF format only when possible.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 573273002: Binary Size tool: Check DWARF format only when possible. (Closed)

Created:
6 years, 3 months ago by Daniel Bratell

Modified:
6 years, 3 months ago

Reviewers:
Andrew Hayden (chromium.org)

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Binary Size tool: Check DWARF format only when possible. The tool can be run with a preprocessed nm file as input and trying to run a DWARF version check in that case won't work. BUG=415084 R=andrewhayden@chromium.org Committed: https://crrev.com/87b3e5c74d8197d28c663dc567f2e683a45c7350 Cr-Commit-Position: refs/heads/master@{#295443}

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	tools/binary_size/run_binary_size_analysis.py	View		1 chunk	+2 lines, -1 line	0 comments	Download

Total messages: 6 (1 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/573273002/1

6 years, 3 months ago (2014-09-18 09:43:59 UTC) #4

commit-bot: I haz the power

Committed patchset #1 (id:1) as 2de01f7023fefb4d666e60a2c5ee54219b6defa6

6 years, 3 months ago (2014-09-18 10:09:07 UTC) #5

commit-bot: I haz the power

6 years, 3 months ago (2014-09-18 10:56:11 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/87b3e5c74d8197d28c663dc567f2e683a45c7350
Cr-Commit-Position: refs/heads/master@{#295443}