tools/binary_size/run_binary_size_analysis.py - Issue 573273002: Binary Size tool: Check DWARF format only when possible.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/binary_size/run_binary_size_analysis.py

Issue 573273002: Binary Size tool: Check DWARF format only when possible. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/binary_size/run_binary_size_analysis.py

diff --git a/tools/binary_size/run_binary_size_analysis.py b/tools/binary_size/run_binary_size_analysis.py

index 71c0975627a78f4e6e4aaf71812c9695fa97ce09..c218effa764a7139285801df6be9dd8b4e2e7d9a 100755

--- a/tools/binary_size/run_binary_size_analysis.py

+++ b/tools/binary_size/run_binary_size_analysis.py

@@ -870,7 +870,8 @@ def main():

print('addr2line: %s' % addr2line_binary)

print('nm: %s' % nm_binary)

- CheckDebugFormatSupport(opts.library, addr2line_binary)

+ if opts.library:

+ CheckDebugFormatSupport(opts.library, addr2line_binary)

symbols = GetNmSymbols(opts.nm_in, opts.nm_out, opts.library,

opts.jobs, opts.verbose is True,

« no previous file with comments | « no previous file | no next file » | no next file with comments »