Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8514)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/common/pepper_permission_util.cc

Issue 573113002: Relax shared module whitelist restriction (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix unit tests Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/shared_module_service_unittest.cc ('k') | chrome/common/pepper_permission_util_unittest.cc » ('j') | chrome/common/pepper_permission_util_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/pepper_permission_util.cc
diff --git a/chrome/common/pepper_permission_util.cc b/chrome/common/pepper_permission_util.cc
index 167687ced298a2377614af8ea891a60bb0c95422..ac01c04843ab0244eee9a5a953c75ee2def511c1 100644
--- a/chrome/common/pepper_permission_util.cc
+++ b/chrome/common/pepper_permission_util.cc
@@ -62,11 +62,6 @@ bool IsExtensionOrSharedModuleWhitelisted(
extension_set->GetByID(it->extension_id);
if (imported_extension &&
SharedModuleInfo::IsSharedModule(imported_extension) &&
- // We check the whitelist explicitly even though the extension should
- // never have been allowed to be installed in the first place if this
- // fails. See SharedModuleService::CheckImports for details.
- SharedModuleInfo::IsExportAllowedByWhitelist(imported_extension,
- host) &&
HostIsInSet(it->extension_id, whitelist)) {
return true;
}
« no previous file with comments | « chrome/browser/extensions/shared_module_service_unittest.cc ('k') | chrome/common/pepper_permission_util_unittest.cc » ('j') | chrome/common/pepper_permission_util_unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698