Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1853)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/extensions/shared_module_service_unittest.cc

Issue 573113002: Relax shared module whitelist restriction (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix unit tests Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/shared_module_service.cc ('k') | chrome/common/pepper_permission_util.cc » ('j') | chrome/common/pepper_permission_util_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/shared_module_service_unittest.cc
diff --git a/chrome/browser/extensions/shared_module_service_unittest.cc b/chrome/browser/extensions/shared_module_service_unittest.cc
index ca121650c5849d9d17ed212a15e1fa1ec46a8423..1a8a2f2ab891f0d5ae1341afa74bea4fc9158c34 100644
--- a/chrome/browser/extensions/shared_module_service_unittest.cc
+++ b/chrome/browser/extensions/shared_module_service_unittest.cc
@@ -268,7 +268,11 @@ TEST_F(SharedModuleServiceUnitTest, WhitelistedImports) {
CreateExtensionImportingModule(shared_module->id(),
nonwhitelisted_id,
"1.0");
- EXPECT_FALSE(InstallExtension(nonwhitelisted_extension.get(), false));
+ // This should succeed because only CRX installer (and by extension the
+ // WebStore Installer) checks the shared module whitelist. InstallExtension
+ // bypasses the whitelist check because the SharedModuleService does not
+ // care about whitelists.
+ EXPECT_TRUE(InstallExtension(nonwhitelisted_extension.get(), false));
}
} // namespace extensions
« no previous file with comments | « chrome/browser/extensions/shared_module_service.cc ('k') | chrome/common/pepper_permission_util.cc » ('j') | chrome/common/pepper_permission_util_unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698