Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Unified Diff: components/nacl/loader/nonsfi/nonsfi_listener.cc

Issue 572973002: NaCl: Simpler validation for main nexe. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fixes for mseaborn Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/nacl/loader/nonsfi/nonsfi_listener.cc
diff --git a/components/nacl/loader/nonsfi/nonsfi_listener.cc b/components/nacl/loader/nonsfi/nonsfi_listener.cc
index cd1aac300a1db4ecf3bdddea8c5b77644b5eef09..dfa1dafaff833373a7791718816540ef95cf7168 100644
--- a/components/nacl/loader/nonsfi/nonsfi_listener.cc
+++ b/components/nacl/loader/nonsfi/nonsfi_listener.cc
@@ -144,8 +144,8 @@ void NonSfiListener::OnStart(const nacl::NaClStartParams& params) {
CHECK(params.process_type == kNativeNaClProcessType);
CHECK(params.nexe_file != IPC::InvalidPlatformFileForTransit());
- CHECK(params.nexe_token_lo == 0);
- CHECK(params.nexe_token_hi == 0);
+ CHECK(params.nexe_file_path_metadata.empty());
Mark Seaborn 2014/10/16 21:58:40 Have you tested this with packaged apps? Packaged
Mark Seaborn 2014/11/13 16:36:28 It looks like you did that in https://codereview.c
+
MainStart(IPC::PlatformFileForTransitToPlatformFile(params.nexe_file));
}

Powered by Google App Engine
This is Rietveld 408576698