components/nacl/common/nacl_types.h - Issue 572973002: NaCl: Simpler validation for main nexe.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/nacl/common/nacl_types.h

Issue 572973002: NaCl: Simpler validation for main nexe. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/nacl/common/nacl_types.h

diff --git a/components/nacl/common/nacl_types.h b/components/nacl/common/nacl_types.h

index 490ec64118976a107658063963ba4015eae803e6..c4c597695b2840a70398d6026473ef175fb98a54 100644

--- a/components/nacl/common/nacl_types.h

+++ b/components/nacl/common/nacl_types.h

@@ -63,8 +63,7 @@ struct NaClStartParams {

~NaClStartParams();

IPC::PlatformFileForTransit nexe_file;

- uint64_t nexe_token_lo;

- uint64_t nexe_token_hi;

+ base::FilePath nexe_file_path;

Mark Seaborn 2014/10/14 17:37:24 Could you comment that this is used only as a key

teravest 2014/10/14 18:15:00 Done.

std::vector<FileDescriptor> handles;

FileDescriptor debug_stub_server_bound_socket;