NaCl: Simpler validation for main nexe.

components/nacl/common/nacl_types.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_NACL_COMMON_NACL_TYPES_H_
 #define COMPONENTS_NACL_COMMON_NACL_TYPES_H_
 
 #include <string>
 #include <vector>
 
@@ skipping 45 matching lines @@
   kPNaClTranslatorProcessType,
   kNumNaClProcessTypes
 };
 
 // Parameters sent to the NaCl process when we start it.
 struct NaClStartParams {
   NaClStartParams();
   ~NaClStartParams();
 
   IPC::PlatformFileForTransit nexe_file;
-  uint64_t nexe_token_lo;
-  uint64_t nexe_token_hi;
+  base::FilePath nexe_file_path;

[Mark Seaborn, 2014/10/14 17:37:24]

Could you comment that this is used only as a key for validation caching? 
Otherwise it looks strange that a filename would be passed to a sandboxed
process that can't open files by name.

Ideally this would be named something more abstract like
"nexe_validation_cache_key", but I suppose the name should match up with the
NaClDescCreateWithFilePathMetadata() API.

So how about "nexe_file_path_metadata"?

[teravest, 2014/10/14 18:15:00]

Done.

 
   std::vector<FileDescriptor> handles;
   FileDescriptor debug_stub_server_bound_socket;
 
   bool validation_cache_enabled;
   std::string validation_cache_key;
   // Chrome version string. Sending the version string over IPC avoids linkage
   // issues in cases where NaCl is not compiled into the main Chromium
   // executable or DLL.
   std::string version;
@@ skipping 70 matching lines @@
   base::ProcessId plugin_pid;
   int plugin_child_id;
 
   // For NaCl <-> renderer crash information reporting.
   base::SharedMemoryHandle crash_info_shmem_handle;
 };
 
 }  // namespace nacl
 
 #endif  // COMPONENTS_NACL_COMMON_NACL_TYPES_H_