Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 572413002: Revert "Roll Clang 214024:216630 (+216684) and switch to CMake (try 2)" (Closed)

Created:
6 years, 3 months ago by Dirk Pranke
Modified:
6 years, 3 months ago
Reviewers:
hans, Nico
CC:
chromium-reviews, eugenis+clang_chromium.org, glider+clang_chromium.org, dmikurube+clang_chromium.org, ukai+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert "Roll Clang 214024:216630 (+216684) and switch to CMake (try 2)" This reverts commit 3853ffa861dc43537f23c21a3fc4104c6f08c3a2. The change broke the Mac10.6 Tests bot on the chromium.webkit waterfall. TBR=hwennborg@chromium.org, thakis@chromium.org BUG=400849 Committed: https://crrev.com/92a7688192af8fae18b20df1b7b6443d996fff8c Cr-Commit-Position: refs/heads/master@{#295132}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+176 lines, -346 lines) Patch
M build/config/compiler/BUILD.gn View 1 chunk +0 lines, -11 lines 0 comments Download
M tools/clang/blink_gc_plugin/BlinkGCPlugin.cpp View 3 chunks +5 lines, -6 lines 0 comments Download
D tools/clang/blink_gc_plugin/CMakeLists.txt View 1 chunk +0 lines, -35 lines 0 comments Download
A tools/clang/blink_gc_plugin/Makefile View 1 chunk +21 lines, -0 lines 0 comments Download
M tools/clang/blink_gc_plugin/tests/test.sh View 3 chunks +14 lines, -17 lines 0 comments Download
D tools/clang/plugins/CMakeLists.txt View 1 chunk +0 lines, -32 lines 0 comments Download
M tools/clang/plugins/FindBadConstructsAction.h View 1 chunk +1 line, -1 line 0 comments Download
M tools/clang/plugins/FindBadConstructsAction.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
A tools/clang/plugins/Makefile View 1 chunk +19 lines, -0 lines 0 comments Download
M tools/clang/plugins/tests/test.sh View 3 chunks +13 lines, -17 lines 0 comments Download
M tools/clang/scripts/blink_gc_plugin_flags.sh View 1 chunk +3 lines, -2 lines 0 comments Download
M tools/clang/scripts/package.sh View 6 chunks +10 lines, -18 lines 0 comments Download
M tools/clang/scripts/repackage.sh View 2 chunks +4 lines, -4 lines 0 comments Download
M tools/clang/scripts/update.sh View 13 chunks +84 lines, -201 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Dirk Pranke
Link to failure: https://build.chromium.org/p/chromium.webkit/builders/Mac10.6%20Tests/builds/26487/steps/compile/logs/stdio
6 years, 3 months ago (2014-09-16 19:48:55 UTC) #1
Dirk Pranke
On 2014/09/16 19:48:55, Dirk Pranke wrote: > Link to failure: > > https://build.chromium.org/p/chromium.webkit/builders/Mac10.6%20Tests/builds/26487/steps/compile/logs/stdio And, original ...
6 years, 3 months ago (2014-09-16 19:49:38 UTC) #2
Dirk Pranke
Committed patchset #1 (id:1) manually as 92a7688 (presubmit successful).
6 years, 3 months ago (2014-09-16 19:53:05 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/92a7688192af8fae18b20df1b7b6443d996fff8c Cr-Commit-Position: refs/heads/master@{#295132}
6 years, 3 months ago (2014-09-16 19:53:08 UTC) #4
hans
6 years, 3 months ago (2014-09-16 19:53:54 UTC) #6
Message was sent while issue was closed. 
Thanks! Sorry for the breakage.

Powered by Google App Engine
This is Rietveld 408576698