Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Unified Diff: tools/clang/blink_gc_plugin/tests/test.sh

Issue 572413002: Revert "Roll Clang 214024:216630 (+216684) and switch to CMake (try 2)" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/clang/blink_gc_plugin/Makefile ('k') | tools/clang/plugins/CMakeLists.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/clang/blink_gc_plugin/tests/test.sh
diff --git a/tools/clang/blink_gc_plugin/tests/test.sh b/tools/clang/blink_gc_plugin/tests/test.sh
index 02c74778415a16aba8149561b99e83ff1d2c1962..d337bca39685928b6427ad6eff335a39808ffc5a 100755
--- a/tools/clang/blink_gc_plugin/tests/test.sh
+++ b/tools/clang/blink_gc_plugin/tests/test.sh
@@ -15,8 +15,7 @@ failed_any_test=
# Prints usage information.
usage() {
echo "Usage: $(basename "${0}")" \
- "<path to clang>" \
- "<path to plugin>"
+ "<Path to the llvm build dir, usually Release+Asserts>"
echo ""
echo " Runs all the libBlinkGCPlugin unit tests"
echo ""
@@ -28,8 +27,8 @@ do_testcase() {
if [ -e "${3}" ]; then
flags="$(cat "${3}")"
fi
- local output="$("${CLANG_PATH}" -c -Wno-c++11-extensions \
- -Xclang -load -Xclang "${PLUGIN_PATH}" \
+ local output="$("${CLANG_DIR}"/bin/clang -c -Wno-c++11-extensions \
+ -Xclang -load -Xclang "${CLANG_DIR}"/lib/lib${LIBNAME}.${LIB} \
-Xclang -add-plugin -Xclang blink-gc-plugin ${flags} ${1} 2>&1)"
local json="${input%cpp}graph.json"
if [ -f "$json" ]; then
@@ -53,26 +52,24 @@ do_testcase() {
if [[ -z "${1}" ]]; then
usage
exit ${E_BADARGS}
-elif [[ -z "${2}" ]]; then
- usage
- exit ${E_BADARGS}
-elif [[ ! -x "${1}" ]]; then
- echo "${1} is not an executable"
- usage
- exit ${E_BADARGS}
-elif [[ ! -f "${2}" ]]; then
- echo "${2} could not be found"
+elif [[ ! -d "${1}" ]]; then
+ echo "${1} is not a directory."
usage
exit ${E_BADARGS}
else
- export CLANG_PATH="${1}"
- export PLUGIN_PATH="${2}"
- echo "Using clang ${CLANG_PATH}..."
- echo "Using plugin ${PLUGIN_PATH}..."
+ export CLANG_DIR="${PWD}/${1}"
+ echo "Using clang directory ${CLANG_DIR}..."
# The golden files assume that the cwd is this directory. To make the script
# work no matter what the cwd is, explicitly cd to there.
cd "$(dirname "${0}")"
+
+ export LIBNAME=$(grep LIBRARYNAME ../Makefile | cut -d ' ' -f 3)
+ if [ "$(uname -s)" = "Linux" ]; then
+ export LIB=so
+ elif [ "$(uname -s)" = "Darwin" ]; then
+ export LIB=dylib
+ fi
fi
for input in *.cpp; do
« no previous file with comments | « tools/clang/blink_gc_plugin/Makefile ('k') | tools/clang/plugins/CMakeLists.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698