Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(526)

Issue 572363002: Remove WEB_ANIMATION_SUPPORTS_FULL_DIRECTION define (Closed)

Created:
6 years, 3 months ago by a.renevier
Modified:
6 years, 3 months ago
Reviewers:
jamesr, ajuma, dglazkov
CC:
blink-reviews, jamesr, shans, rjwright, Mike Lawther (Google), blink-reviews-animation_chromium.org, Timothy Loh, abarth-chromium, dstockwell, dglazkov+blink, darktears, Steve Block, Eric Willigers
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Remove WEB_ANIMATION_SUPPORTS_FULL_DIRECTION define This is the 4th and last part of accelerated direction control. Now that legacy path in compositor has been removed, the WEB_ANIMATION_SUPPORTS_FULL_DIRECTION define becomes unneeded. It builds on top of https://codereview.chromium.org/227733004, https://codereview.chromium.org/225183014 and https://codereview.chromium.org/576553002/ BUG=348071 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182101

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M public/platform/WebCompositorAnimation.h View 1 chunk +0 lines, -1 line 1 comment Download

Messages

Total messages: 12 (5 generated)
a.renevier
6 years, 3 months ago (2014-09-16 18:11:34 UTC) #2
ajuma
non-owner lgtm
6 years, 3 months ago (2014-09-16 18:13:52 UTC) #3
jamesr
lgtm https://codereview.chromium.org/572363002/diff/1/public/platform/WebCompositorAnimation.h File public/platform/WebCompositorAnimation.h (right): https://codereview.chromium.org/572363002/diff/1/public/platform/WebCompositorAnimation.h#newcode8 public/platform/WebCompositorAnimation.h:8: #define WEB_ANIMATION_SUPPORTS_FRACTIONAL_ITERATIONS 1 can this one go too?
6 years, 3 months ago (2014-09-16 19:06:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/572363002/1
6 years, 3 months ago (2014-09-16 19:16:28 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/23587)
6 years, 3 months ago (2014-09-16 19:22:36 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/572363002/1
6 years, 3 months ago (2014-09-16 20:27:19 UTC) #11
commit-bot: I haz the power
6 years, 3 months ago (2014-09-16 21:25:43 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 182101

Powered by Google App Engine
This is Rietveld 408576698