Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 572353003: Fix RemoveFromScrollTree and RemoveFromClipTree (Closed)

Created:
6 years, 3 months ago by Ian Vollick
Modified:
6 years, 3 months ago
Reviewers:
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2125
Project:
chromium
Visibility:
Public.

Description

Fix RemoveFromScrollTree and RemoveFromClipTree These functions should set needs commit, but didn't. This lead to stale pointers in the impl tree. BUG=413743, 403866 TBR=danakj@chromium.org Review URL: https://codereview.chromium.org/572483002 Cr-Commit-Position: refs/heads/master@{#294749} (cherry picked from commit 66133e86b6d79534605539aa684a248e6b6205bf) Committed: https://chromium.googlesource.com/chromium/src/+/d1ea9b5a6670389019344279d5bb10bb7edfd139

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -33 lines) Patch
M cc/layers/layer.h View 2 chunks +8 lines, -8 lines 0 comments Download
M cc/layers/layer.cc View 3 chunks +13 lines, -17 lines 0 comments Download
M cc/layers/layer_unittest.cc View 1 chunk +58 lines, -0 lines 0 comments Download
M cc/trees/tree_synchronizer.cc View 2 chunks +14 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/572353003/1
6 years, 3 months ago (2014-09-18 04:02:57 UTC) #2
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/57517) ios_rel_device_ninja on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ninja/builds/10964) mac_chromium_compile_dbg ...
6 years, 3 months ago (2014-09-18 04:05:46 UTC) #4
Ian Vollick
6 years, 3 months ago (2014-09-18 04:08:24 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as d1ea9b5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698