Fix RemoveFromScrollTree and RemoveFromClipTree

Fix RemoveFromScrollTree and RemoveFromClipTree

These functions should set needs commit, but didn't. This lead to stale
pointers in the impl tree.

BUG=413743, 403866
Committed: https://crrev.com/66133e86b6d79534605539aa684a248e6b6205bf
Cr-Commit-Position: refs/heads/master@{#294749}

[Ian Vollick, 2014-09-13 03:22:25]

vollick@chromium.org changed reviewers:
+ danakj@chromium.org

[Ian Vollick, 2014-09-13 03:22:25]

\o/

[danakj, 2014-09-13 12:49:42]

LTM

https://codereview.chromium.org/572483002/diff/1/cc/layers/layer_unittest.cc
File cc/layers/layer_unittest.cc (right):

https://codereview.chromium.org/572483002/diff/1/cc/layers/layer_unittest.cc#...
cc/layers/layer_unittest.cc:359: EXPECT_SET_NEEDS_COMMIT(1, child2 = NULL);
can you also reset child1->needs_push_properties() before this and check it
becomes true?

https://codereview.chromium.org/572483002/diff/1/cc/layers/layer_unittest.cc#...
cc/layers/layer_unittest.cc:384: EXPECT_SET_NEEDS_COMMIT(1, child1 = NULL);
can you also reset child2->needs_push_properties() before this and check it
becomes true?

[danakj, 2014-09-13 12:49:48]

er, LGTM!

[Ian Vollick, 2014-09-13 14:51:23]

Thanks!

https://codereview.chromium.org/572483002/diff/1/cc/layers/layer_unittest.cc
File cc/layers/layer_unittest.cc (right):

https://codereview.chromium.org/572483002/diff/1/cc/layers/layer_unittest.cc#...
cc/layers/layer_unittest.cc:359: EXPECT_SET_NEEDS_COMMIT(1, child2 = NULL);
On 2014/09/13 12:49:42, danakj wrote:
> can you also reset child1->needs_push_properties() before this and check it
> becomes true?

Done.

https://codereview.chromium.org/572483002/diff/1/cc/layers/layer_unittest.cc#...
cc/layers/layer_unittest.cc:384: EXPECT_SET_NEEDS_COMMIT(1, child1 = NULL);
On 2014/09/13 12:49:42, danakj wrote:
> can you also reset child2->needs_push_properties() before this and check it
> becomes true?

Done.

[Ian Vollick, 2014-09-13 14:51:27]

The CQ bit was checked by vollick@chromium.org

[commit-bot: I haz the power, 2014-09-13 14:52:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/572483002/20001

[commit-bot: I haz the power, 2014-09-13 20:38:33]

Committed patchset #2 (id:20001) as 11a4fc62f0bbf6f3dc1ffcbfa76a2daeb151296e

[commit-bot: I haz the power, 2014-09-13 20:41:58]

Patchset 2 (id:??) landed as
https://crrev.com/66133e86b6d79534605539aa684a248e6b6205bf
Cr-Commit-Position: refs/heads/master@{#294749}