Move ChangeVersionWrapper destructor out of line.

Move ChangeVersionWrapper destructor out of line.

With clang/win, the vtable of ChangeVersionWrapper ends up being referenced
for some reason, which causes the destructor to be defined, which requires
a definition of SQLErrorData. So move the destructor out of line, where
the definition is available.

BUG=413478
R=michaeln@chromium.org, rnk@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182093

[Nico, 2014-09-16 17:50:04]

thakis@chromium.org changed reviewers:
+ rnk@chromium.org

[Reid Kleckner, 2014-09-16 17:51:12]

lgtm

https://codereview.chromium.org/572343002/diff/1/Source/modules/webdatabase/C...
File Source/modules/webdatabase/ChangeVersionWrapper.h (right):

https://codereview.chromium.org/572343002/diff/1/Source/modules/webdatabase/C...
Source/modules/webdatabase/ChangeVersionWrapper.h:41: static
PassRefPtrWillBeRawPtr<ChangeVersionWrapper> create(const String& oldVersion,
const String& newVersion) { return adoptRefWillBeNoop(new
ChangeVersionWrapper(oldVersion, newVersion)); }
WebKit style, lol.

[Nico, 2014-09-16 17:55:35]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2014-09-16 17:56:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/572343002/1

[commit-bot: I haz the power, 2014-09-16 18:06:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-16 18:06:40]

Try jobs failed on following builders:
  blink_presubmit on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/1...)

[Nico, 2014-09-16 18:22:58]

thakis@chromium.org changed reviewers:
+ michaeln@chromium.org

[Nico, 2014-09-16 18:22:58]

michaeln: OWNERS stamp, please :-)

[michaeln, 2014-09-16 19:17:51]

lgtm, see comment about 'virtual'

https://codereview.chromium.org/572343002/diff/1/Source/modules/webdatabase/C...
File Source/modules/webdatabase/ChangeVersionWrapper.h (right):

https://codereview.chromium.org/572343002/diff/1/Source/modules/webdatabase/C...
Source/modules/webdatabase/ChangeVersionWrapper.h:41: static
PassRefPtrWillBeRawPtr<ChangeVersionWrapper> create(const String& oldVersion,
const String& newVersion) { return adoptRefWillBeNoop(new
ChangeVersionWrapper(oldVersion, newVersion)); }
On 2014/09/16 17:51:11, Reid Kleckner wrote:
> WebKit style, lol.

haha, there has not yet been a line of code written ever that is too long

https://codereview.chromium.org/572343002/diff/1/Source/modules/webdatabase/C...
Source/modules/webdatabase/ChangeVersionWrapper.h:43: ~ChangeVersionWrapper();
can you use the virtual keyword here since SQLTransactionWrapper declares it as
virtual

[Nico, 2014-09-16 19:43:01]

Thanks!

https://codereview.chromium.org/572343002/diff/1/Source/modules/webdatabase/C...
File Source/modules/webdatabase/ChangeVersionWrapper.h (right):

https://codereview.chromium.org/572343002/diff/1/Source/modules/webdatabase/C...
Source/modules/webdatabase/ChangeVersionWrapper.h:43: ~ChangeVersionWrapper();
On 2014/09/16 19:17:51, michaeln wrote:
> can you use the virtual keyword here since SQLTransactionWrapper declares it
as
> virtual

Done.

[Nico, 2014-09-16 20:34:36]

Committed patchset #1 (id:1) manually as 182093 (tree was closed).

[Nico, 2014-09-17 00:03:18]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/563143005/ by thakis@chromium.org.

The reason for reverting is: No longer needed, we fixed this in clang instead
(see BUG=)..