Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Unified Diff: Source/modules/webdatabase/ChangeVersionWrapper.h

Issue 572343002: Move ChangeVersionWrapper destructor out of line. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/modules/webdatabase/ChangeVersionWrapper.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/webdatabase/ChangeVersionWrapper.h
diff --git a/Source/modules/webdatabase/ChangeVersionWrapper.h b/Source/modules/webdatabase/ChangeVersionWrapper.h
index 838c261d7e706bb890c7c9f0ae5454434e3d4d0b..8ce7b2fc990e5d8ec93cba9c3d9cbff24f033a81 100644
--- a/Source/modules/webdatabase/ChangeVersionWrapper.h
+++ b/Source/modules/webdatabase/ChangeVersionWrapper.h
@@ -40,6 +40,8 @@ class ChangeVersionWrapper FINAL : public SQLTransactionWrapper {
public:
static PassRefPtrWillBeRawPtr<ChangeVersionWrapper> create(const String& oldVersion, const String& newVersion) { return adoptRefWillBeNoop(new ChangeVersionWrapper(oldVersion, newVersion)); }
Reid Kleckner 2014/09/16 17:51:11 WebKit style, lol.
michaeln 2014/09/16 19:17:50 haha, there has not yet been a line of code writte
+ ~ChangeVersionWrapper();
michaeln 2014/09/16 19:17:51 can you use the virtual keyword here since SQLTran
Nico 2014/09/16 19:43:00 Done.
+
virtual void trace(Visitor* visitor) OVERRIDE { SQLTransactionWrapper::trace(visitor); }
virtual bool performPreflight(SQLTransactionBackend*) OVERRIDE;
virtual bool performPostflight(SQLTransactionBackend*) OVERRIDE;
« no previous file with comments | « no previous file | Source/modules/webdatabase/ChangeVersionWrapper.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698