Issue 5723002: Make RegExp character class match JSC.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5723002: Make RegExp character class match JSC. (Closed)

Created:
10 years ago by Lasse Reichstein

Modified:
9 years, 6 months ago

Reviewers:
Erik Corry, Mads Ager (chromium)

CC:
v8-dev

Visibility:
Public.

Description

Make RegExp character class match JSC. See http://trac.webkit.org/changeset/73594

Patch Set 1 #

Total comments: 3

Patch Set 2 : Address review comments. Add tests #

Created: 10 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -11 lines)			Patch
	M	src/parser.cc	View	1	4 chunks	+25 lines, -11 lines	0 comments	Download
	M	test/mjsunit/regexp.js	View	1	2 chunks	+12 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Erik Corry

10 years ago (2010-12-10 14:02:51 UTC) #2

Can't we add some tests to our own collection?  Even if they are copied from the
WebKit tests then it's nicer to get future failures before we roll to Chromium.

LGTM

http://codereview.chromium.org/5723002/diff/1/src/parser.cc
File src/parser.cc (right):

http://codereview.chromium.org/5723002/diff/1/src/parser.cc#newcode4455
src/parser.cc:4455: if (char_class) {
char_class == kInvalidCharClass?

http://codereview.chromium.org/5723002/diff/1/src/parser.cc#newcode4489
src/parser.cc:4489: uc16 char_class_2 = 0;
kInvalidCharClass

http://codereview.chromium.org/5723002/diff/1/src/parser.cc#newcode4491
src/parser.cc:4491: if (char_class || char_class_2) {
And here.

Expand Messages | Collapse Messages