Chromium Code Reviews
Help | Chromium Project | Sign in
(677)

Issue 5723002: Make RegExp character class match JSC. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 4 months ago by Lasse Reichstein
Modified:
2 years, 10 months ago
CC:
v8-dev_googlegroups.com
Visibility:
Public.

Description

Make RegExp character class match JSC.
See http://trac.webkit.org/changeset/73594

Patch Set 1 #

Total comments: 3

Patch Set 2 : Address review comments. Add tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -11 lines) Lint Patch
M src/parser.cc View 1 4 chunks +25 lines, -11 lines 0 comments 0 errors Download
M test/mjsunit/regexp.js View 1 2 chunks +12 lines, -0 lines 0 comments ? errors Download
Trybot results:
Commit:

Messages

Total messages: 2
Lasse Reichstein
Should make us match the Webkit layout tests.
3 years, 4 months ago #1
Erik Corry
3 years, 4 months ago #2
Can't we add some tests to our own collection?  Even if they are copied from the
WebKit tests then it's nicer to get future failures before we roll to Chromium.

LGTM

http://codereview.chromium.org/5723002/diff/1/src/parser.cc
File src/parser.cc (right):

http://codereview.chromium.org/5723002/diff/1/src/parser.cc#newcode4455
src/parser.cc:4455: if (char_class) {
char_class == kInvalidCharClass?

http://codereview.chromium.org/5723002/diff/1/src/parser.cc#newcode4489
src/parser.cc:4489: uc16 char_class_2 = 0;
kInvalidCharClass

http://codereview.chromium.org/5723002/diff/1/src/parser.cc#newcode4491
src/parser.cc:4491: if (char_class || char_class_2) {
And here.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6