components/web_contents_delegate_android/android/java/src/org/chromium/components/web_contents_delegate_android/WebContentsDelegateAndroid.java - Issue 572013002: Removing ContentViewCore dependencies from direct WebContents functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/web_contents_delegate_android/android/java/src/org/chromium/components/web_contents_delegate_android/WebContentsDelegateAndroid.java

Issue 572013002: Removing ContentViewCore dependencies from direct WebContents functions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed nits. Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« android_webview/java/src/org/chromium/android_webview/AwWebContentsDelegateAdapter.java ('K') | « chrome/android/sync_shell/javatests/src/chromium/chrome/browser/sync/SyncTest.java ('k') | components/web_contents_delegate_android/web_contents_delegate_android.cc » ('j') | content/public/android/javatests/src/org/chromium/content/browser/ContentViewTestBase.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/web_contents_delegate_android/android/java/src/org/chromium/components/web_contents_delegate_android/WebContentsDelegateAndroid.java

diff --git a/components/web_contents_delegate_android/android/java/src/org/chromium/components/web_contents_delegate_android/WebContentsDelegateAndroid.java b/components/web_contents_delegate_android/android/java/src/org/chromium/components/web_contents_delegate_android/WebContentsDelegateAndroid.java

index fff738c6744f33de58fee1a205cc381b71a0030a..74abb4ee686f8c1faf1745f6d9e48ccee5040836 100644

--- a/components/web_contents_delegate_android/android/java/src/org/chromium/components/web_contents_delegate_android/WebContentsDelegateAndroid.java

+++ b/components/web_contents_delegate_android/android/java/src/org/chromium/components/web_contents_delegate_android/WebContentsDelegateAndroid.java

@@ -8,7 +8,7 @@ import android.view.KeyEvent;

import org.chromium.base.CalledByNative;

import org.chromium.base.JNINamespace;

-import org.chromium.content.browser.ContentViewCore;

+import org.chromium.content_public.browser.WebContents;

/**

* Java peer of the native class of the same name.

@@ -141,7 +141,7 @@ public class WebContentsDelegateAndroid {

* either of ContentViewCore.ContinuePendingReload or ContentViewCore.CancelPendingReload.

Ted C 2014/10/10 17:00:53 This comment should be updated to NavigationContro

AKVT 2014/10/11 10:51:59 Done.

@CalledByNative

- public void showRepostFormWarningDialog(ContentViewCore contentViewCore) {

+ public void showRepostFormWarningDialog(WebContents webContents) {

}

@CalledByNative