Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4655)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/Tab.java

Issue 572013002: Removing ContentViewCore dependencies from direct WebContents functions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed nits. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/Tab.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/Tab.java b/chrome/android/java/src/org/chromium/chrome/browser/Tab.java
index e2eb139ef4ac760eac5468db6cb97d31931223eb..09f4ea003552afd6dcdf3882224ea709d6ac0afa 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/Tab.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/Tab.java
@@ -209,17 +209,17 @@ public class Tab implements NavigationClient {
}
@Override
- public void showRepostFormWarningDialog(final ContentViewCore contentViewCore) {
+ public void showRepostFormWarningDialog(final WebContents webContents) {
RepostFormWarningDialog warningDialog = new RepostFormWarningDialog(
new Runnable() {
@Override
public void run() {
- getWebContents().getNavigationController().cancelPendingReload();
+ webContents.getNavigationController().cancelPendingReload();
}
}, new Runnable() {
@Override
public void run() {
- getWebContents().getNavigationController().continuePendingReload();
+ webContents.getNavigationController().continuePendingReload();
}
});
Activity activity = (Activity) mContext;
@@ -467,7 +467,7 @@ public class Tab implements NavigationClient {
* @return Whether or not the tab has something valid to render.
*/
public boolean isReady() {
- return mNativePage != null || (mContentViewCore != null && mContentViewCore.isReady());
+ return mNativePage != null || (getWebContents() != null && getWebContents().isReady());
}
/**

Powered by Google App Engine
This is Rietveld 408576698