Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(614)

Issue 571713002: pkg/docgen: include all package libraries under lib/, except those under lib/src (Closed)

Created:
6 years, 3 months ago by kevmoo
Modified:
6 years, 3 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

pkg/docgen: include all package libraries under lib/, except those under lib/src Also updated package dependencies BUG= https://code.google.com/p/dart/issues/detail?id=18554 R=alanknight@google.com Committed: https://code.google.com/p/dart/source/detail?r=40246

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -8 lines) Patch
M pkg/docgen/lib/src/generator.dart View 1 chunk +16 lines, -7 lines 0 comments Download
M pkg/docgen/pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M pkg/docgen/test/generate_json_test.dart View 1 chunk +3 lines, -0 lines 0 comments Download
A pkg/docgen/test/multi_library_code/lib/src/src_lib.dart View 1 chunk +5 lines, -0 lines 0 comments Download
A pkg/docgen/test/multi_library_code/lib/src/src_lib_part.dart View 1 chunk +3 lines, -0 lines 0 comments Download
A pkg/docgen/test/multi_library_code/lib/sublib_dir/sub_lib.dart View 1 chunk +5 lines, -0 lines 0 comments Download
A pkg/docgen/test/multi_library_code/lib/sublib_dir/sub_lib_part.dart View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
kevmoo
I think changes have to be made to the viewer as well, but this is ...
6 years, 3 months ago (2014-09-13 01:54:08 UTC) #2
Alan Knight
lgtm
6 years, 3 months ago (2014-09-14 18:30:55 UTC) #3
kevmoo
6 years, 3 months ago (2014-09-15 15:04:28 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 40246 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698