Chromium Code Reviews
Help | Chromium Project | Sign in
(411)

Issue 5717008: Use make_scoped_refptr for RefCounted parameter to NewRunnableMethod(). (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 4 months ago by willchan
Modified:
2 years, 11 months ago
Reviewers:
Nico, pfeldman, loislo
CC:
chromium-reviews_chromium.org
Visibility:
Public.

Description

Use make_scoped_refptr for RefCounted parameter to NewRunnableMethod().

BUG=28083
TEST=builds

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69205

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Lint Patch
M chrome/browser/debugger/devtools_http_protocol_handler.cc View 1 chunk +1 line, -3 lines 0 comments 0 errors Download
Commit:

Messages

Total messages: 5
willchan
3 years, 4 months ago #1
Nico
LG
3 years, 4 months ago #2
pfeldman1
3 years, 4 months ago #3
willchan
Sorry, I just woke up. I'll look at this when I get into the office ...
3 years, 4 months ago #4
pfeldman
3 years, 4 months ago #5
I already left, but I have investigated it a bit. Sounds like a client code
problem - no need to revert. Will fix on our side.
On Dec 15, 2010 9:47 PM, "William Chan (ι™ˆζ™Ίζ˜Œ)" <willchan@chromium.org> wrote:
> Sorry, I just woke up. I'll look at this when I get into the office and
> either revert it or do a quick fix.
>
> On Wed, Dec 15, 2010 at 5:18 AM, <pfeldman@google.com> wrote:
>
>> http://codereview.chromium.org/5717008/
>>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6