Chromium Code Reviews
Help | Chromium Project | Sign in
(120)

Issue 5717008: Use make_scoped_refptr for RefCounted parameter to NewRunnableMethod(). (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 5 months ago by willchan no longer on Chromium
Modified:
4 years ago
Reviewers:
Nico, pfeldman, loislo
CC:
chromium-reviews
Visibility:
Public.

Description

Use make_scoped_refptr for RefCounted parameter to NewRunnableMethod(). BUG=28083 TEST=builds Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69205

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M chrome/browser/debugger/devtools_http_protocol_handler.cc View 1 chunk +1 line, -3 lines 0 comments Download
Commit: CQ not working?

Messages

Total messages: 5 (0 generated)
willchan no longer on Chromium
4 years, 5 months ago (2010-12-14 22:07:55 UTC) #1
Nico
LG
4 years, 5 months ago (2010-12-15 00:34:08 UTC) #2
pfeldman1
4 years, 5 months ago (2010-12-15 13:18:21 UTC) #3
willchan no longer on Chromium
Sorry, I just woke up. I'll look at this when I get into the office ...
4 years, 5 months ago (2010-12-15 18:47:10 UTC) #4
pfeldman
4 years, 5 months ago (2010-12-15 18:50:26 UTC) #5
I already left, but I have investigated it a bit. Sounds like a client code
problem - no need to revert. Will fix on our side.
On Dec 15, 2010 9:47 PM, "William Chan (ι™ˆζ™Ίζ˜Œ)" <willchan@chromium.org> wrote:
> Sorry, I just woke up. I'll look at this when I get into the office and
> either revert it or do a quick fix.
>
> On Wed, Dec 15, 2010 at 5:18 AM, <pfeldman@google.com> wrote:
>
>> http://codereview.chromium.org/5717008/
>>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld ec887be