Issue 5717008: Use make_scoped_refptr for RefCounted parameter to NewRunnableMethod().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5717008: Use make_scoped_refptr for RefCounted parameter to NewRunnableMethod(). (Closed)

Created:
10 years ago by willchan no longer on Chromium

Modified:
9 years, 7 months ago

Reviewers:
Nico, pfeldman, loislo

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Use make_scoped_refptr for RefCounted parameter to NewRunnableMethod(). BUG=28083 TEST=builds Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69205

Patch Set 1 #

Created: 10 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -3 lines)			Patch
	M	chrome/browser/debugger/devtools_http_protocol_handler.cc	View		1 chunk	+1 line, -3 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

willchan no longer on Chromium

Sorry, I just woke up. I'll look at this when I get into the office ...

10 years ago (2010-12-15 18:47:10 UTC) #4

pfeldman

10 years ago (2010-12-15 18:50:26 UTC) #5

I already left, but I have investigated it a bit. Sounds like a client code
problem - no need to revert. Will fix on our side.
On Dec 15, 2010 9:47 PM, "William Chan (陈智昌)" <willchan@chromium.org> wrote:
> Sorry, I just woke up. I'll look at this when I get into the office and
> either revert it or do a quick fix.
>
> On Wed, Dec 15, 2010 at 5:18 AM, <pfeldman@google.com> wrote:
>
>> http://codereview.chromium.org/5717008/
>>

Expand Messages | Collapse Messages