Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4858)

Unified Diff: chrome/browser/debugger/devtools_http_protocol_handler.cc

Issue 5717008: Use make_scoped_refptr for RefCounted parameter to NewRunnableMethod(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/debugger/devtools_http_protocol_handler.cc
diff --git a/chrome/browser/debugger/devtools_http_protocol_handler.cc b/chrome/browser/debugger/devtools_http_protocol_handler.cc
index c237e640a98f59d854bd4374896c26d4bf965596..e60045f6830913f55c3cfc5499a3c147150277fc 100644
--- a/chrome/browser/debugger/devtools_http_protocol_handler.cc
+++ b/chrome/browser/debugger/devtools_http_protocol_handler.cc
@@ -156,15 +156,13 @@ void DevToolsHttpProtocolHandler::OnClose(HttpListenSocket* socket) {
socket_to_requests_io_.erase(socket);
}
- // This can't use make_scoped_refptr because |socket| is already deleted
- // when this runs -- http://crbug.com/59930
BrowserThread::PostTask(
BrowserThread::UI,
FROM_HERE,
NewRunnableMethod(
this,
&DevToolsHttpProtocolHandler::OnCloseUI,
- socket));
+ make_scoped_refptr(socket)));
}
void DevToolsHttpProtocolHandler::OnHttpRequestUI(
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698