Mac: Configure Breakpad to run in-process on Yosemite.

Mac: Configure Breakpad to run in-process on Yosemite.

Configure Breakpad to run in-process on Yosemite by setting the
BREAKPAD_IN_PROCESS option.

Roll breakpad r1359 -> r1375.

r1375 Mac: Add support for in-process crash reporting to Breakpad.
r1374 This CL initialize NSData in HTTPMultipartUpload.m to nil.
r1373 Update processor.gyp file with new files added as part of microdump
r1372 Introduce stub microdump processor classes.
r1371 Rename gyp variable use_titlecase_in_grd_files -> use_titlecase_in_grd.
r1370 Extract DumpContext base class from MinidumpContext
r1369 Back out trunk r1367.
r1368 Adding possibility for client to upload the file
r1367 Support for multiple upload files in CrashReportSender/HTTPUpload
r1366 constructor init list in wrong order in CrashGenerationServer
r1365 update svn:ignore
r1364 make "make install" also install headers and pkgconfig files
r1363 Set 32 bits iOS app to use vm_region_recurse_64.
r1362 update svn:ignore lists
r1361 Update lss from r24 to r31.
r1360 upload_system_symbols: Use the Go1.3 improvements to debug/macho.

BUG=414239
Committed: https://crrev.com/db25b4b237b4723e94997a092f9227e770549665
Cr-Commit-Position: refs/heads/master@{#295094}

[Andre, 2014-09-12 21:27:11]

andresantoso@chromium.org changed reviewers:
+ mark@chromium.org

[Mark Mentovai, 2014-09-12 21:52:21]

https://codereview.chromium.org/571663002/diff/1/components/crash/app/breakpa...
File components/crash/app/breakpad_mac.mm (right):

https://codereview.chromium.org/571663002/diff/1/components/crash/app/breakpa...
components/crash/app/breakpad_mac.mm:224: [breakpad_config
setObject:@(base::mac::IsOSYosemiteOrLater())
1. Can we avoid setting this key altogether if we’d set it to NO?

2. Since we’re only expecting this to work in the browser process, can we only
set this if we’re in that process?

[Andre, 2014-09-12 23:00:14]

Thanks Mark, I think it's now ready for your full review.

https://codereview.chromium.org/571663002/diff/1/components/crash/app/breakpa...
File components/crash/app/breakpad_mac.mm (right):

https://codereview.chromium.org/571663002/diff/1/components/crash/app/breakpa...
components/crash/app/breakpad_mac.mm:224: [breakpad_config
setObject:@(base::mac::IsOSYosemiteOrLater())
On 2014/09/12 21:52:20, Mark Mentovai wrote:
> 1. Can we avoid setting this key altogether if we’d set it to NO?
> 
> 2. Since we’re only expecting this to work in the browser process, can we only
> set this if we’re in that process?

Done.

[Mark Mentovai, 2014-09-15 13:23:53]

LGTM

[Andre, 2014-09-15 23:25:10]

Uploaded patch 3 with DEPS roll.
Mark PTAL.

[Mark Mentovai, 2014-09-16 00:55:29]

LGTM if Maria likes it too.

[Andre, 2014-09-16 05:13:49]

andresantoso@chromium.org changed reviewers:
+ mmandlis@chromium.org

[Andre, 2014-09-16 05:13:50]

Maria, please review.
I removed the .h files from breakpad.gyp.

[mmandlis, 2014-09-16 05:48:45]

On 2014/09/16 05:13:50, Andre wrote:
> Maria, please review.
> I removed the .h files from breakpad.gyp.

LGTM

Thanks for doing this change.

[Primiano Tucci (use gerrit), 2014-09-16 07:03:51]

LGTM, sorry for not having done this yet.

Can you just mention "Roll breakpad r1359 -> r1375" in the cl title and add the
changelist summary below to the message? This is usually useful data when
grepping / bisecting chromium git logs.
Thanks

r1375 Mac: Add support for in-process crash reporting to Breakpad.
r1374 This CL initialize NSData in HTTPMultipartUpload.m to nil.
r1373 Update processor.gyp file with new files added as part of microdump
r1372 Introduce stub microdump processor classes.
r1371 Rename gyp variable use_titlecase_in_grd_files -> use_titlecase_in_grd.
r1370 Extract DumpContext base class from MinidumpContext
r1369 Back out trunk r1367.
r1368 Adding possibility for client to upload the file
r1367 Support for multiple upload files in CrashReportSender/HTTPUpload
r1366 constructor init list in wrong order in CrashGenerationServer
r1365 update svn:ignore
r1364 make "make install" also install headers and pkgconfig files
r1363 Set 32 bits iOS app to use vm_region_recurse_64.
r1362 update svn:ignore lists
r1361 Update lss from r24 to r31.
r1360 upload_system_symbols: Use the Go1.3 improvements to debug/macho.

[Andre, 2014-09-16 16:18:45]

On 2014/09/16 07:03:51, Primiano Tucci wrote:
> LGTM, sorry for not having done this yet.
> 
> Can you just mention "Roll breakpad r1359 -> r1375" in the cl title and add
the
> changelist summary below to the message? This is usually useful data when
> grepping / bisecting chromium git logs.
> Thanks
> 
> r1375 Mac: Add support for in-process crash reporting to Breakpad.
> r1374 This CL initialize NSData in HTTPMultipartUpload.m to nil.
> r1373 Update processor.gyp file with new files added as part of microdump
> r1372 Introduce stub microdump processor classes.
> r1371 Rename gyp variable use_titlecase_in_grd_files -> use_titlecase_in_grd.
> r1370 Extract DumpContext base class from MinidumpContext
> r1369 Back out trunk r1367.
> r1368 Adding possibility for client to upload the file
> r1367 Support for multiple upload files in CrashReportSender/HTTPUpload
> r1366 constructor init list in wrong order in CrashGenerationServer
> r1365 update svn:ignore
> r1364 make "make install" also install headers and pkgconfig files
> r1363 Set 32 bits iOS app to use vm_region_recurse_64.
> r1362 update svn:ignore lists
> r1361 Update lss from r24 to r31.
> r1360 upload_system_symbols: Use the Go1.3 improvements to debug/macho.

Done.

[Andre, 2014-09-16 16:20:16]

andresantoso@chromium.org changed reviewers:
+ rsesek@chromium.org

[Andre, 2014-09-16 16:20:17]

+rsesek for components/crash.

[Robert Sesek, 2014-09-16 16:35:36]

LGTM

[Andre, 2014-09-16 16:36:37]

The CQ bit was checked by andresantoso@chromium.org

[commit-bot: I haz the power, 2014-09-16 16:38:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/571663002/80001

[commit-bot: I haz the power, 2014-09-16 17:35:35]

Committed patchset #5 (id:80001) as f8b387900775a427d62b7134ef7819e4f2b518fa

[commit-bot: I haz the power, 2014-09-16 17:36:54]

Patchset 5 (id:??) landed as
https://crrev.com/db25b4b237b4723e94997a092f9227e770549665
Cr-Commit-Position: refs/heads/master@{#295094}