Mac: Configure Breakpad to run in-process on Yosemite.

components/crash/app/breakpad_mac.mm

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "components/crash/app/breakpad_mac.h"
 
 #include <CoreFoundation/CoreFoundation.h>
 #import <Foundation/Foundation.h>
 
 #include "base/auto_reset.h"
@@ skipping 200 matching lines @@
   // when the application crashes, and provide the user with the option to
   // restart it.
   if (is_browser)
     [breakpad_config setObject:@"NO" forKey:@BREAKPAD_SEND_AND_EXIT];
 
   base::FilePath dir_crash_dumps;
   GetBreakpadClient()->GetCrashDumpLocation(&dir_crash_dumps);
   [breakpad_config setObject:base::SysUTF8ToNSString(dir_crash_dumps.value())
                       forKey:@BREAKPAD_DUMP_DIRECTORY];
 
+  // Temporarily run Breakpad in-process on 10.10 and later because APIs that
+  // it depends on got broken (http://crbug.com/386208).
+  // This can catch crashes in the browser process only.
+  [breakpad_config setObject:@(base::mac::IsOSYosemiteOrLater())

[Mark Mentovai, 2014/09/12 21:52:20]

1. Can we avoid setting this key altogether if we’d set it to NO?

2. Since we’re only expecting this to work in the browser process, can we only
set this if we’re in that process?

[Andre, 2014/09/12 23:00:13]

Done.

+                      forKey:@BREAKPAD_IN_PROCESS];
+
   // Initialize Breakpad.
   gBreakpadRef = BreakpadCreate(breakpad_config);
   if (!gBreakpadRef) {
     LOG_IF(ERROR, base::mac::AmIBundled()) << "Breakpad initializaiton failed";
     return;
   }
 
   // Initialize the scoped crash key system.
   base::debug::SetCrashKeyReportingFunctions(&SetCrashKeyValueImpl,
                                              &ClearCrashKeyValueImpl);
@@ skipping 39 matching lines @@
 
   // Store process type in crash dump.
   SetCrashKeyValue(@"ptype", process_type);
 
   NSString* pid_value =
       [NSString stringWithFormat:@"%d", static_cast<unsigned int>(getpid())];
   SetCrashKeyValue(@"pid", pid_value);
 }
 
 }  // namespace breakpad